[pull] main from junit-team:main #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Being able to attach files such as screenshots or extra log files to a
test is useful to diagnose the outcome of tests. This PR adds an API for
Jupiter test authors to do so (`TestReporter.publishFile`) and includes
it when writing the Open Test Reporting XML output (in
`OpenTestReportGeneratingListener`) via a new method on
`TestExecutionListener`. Moreover, it adds `OutputDirectoryProvider` to
`EngineDiscoveryRequest` so other engines can also attach files and
write them to the same output directory and makes it available to
`TestExecutionListener` implementations via `TestPlan`.
The default location of the XML output is changed from
`OUTPUT_DIR/junit-platform-events-*.xml` to
`OUTPUT_DIR/open-test-report.xml`. The output directory can be made
unique by using the `{uniqueNumber}` placeholder in the
`junit.platform.reporting.output.dir` configuration parameter.
Resolves #3997.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Prior to this commit, log messages for @TempDir retention looked similar to the following. INFO: Skipping cleanup of temp dir <path> due to cleanup mode configuration. However, the lack of information about which @TempDir declaration was affected did not provide sufficient information to users. To improve diagnostics, log messages for @TempDir retention now include the configured CleanupMode and describe the AnnotatedElement (field, constructor parameter, or method parameter), as in the following examples. Field: INFO: Skipping cleanup of temp dir <path> for field TestCase.tempDir due to CleanupMode.NEVER. Constructor Parameter: INFO: Skipping cleanup of temp dir <path> for parameter 'tempDir' in constructor TestCase(TestInfo, Path) due to CleanupMode.ON_SUCCESS. Method Parameter: INFO: Skipping cleanup of temp dir <path> for parameter 'tempDir' in method test(TestInfo, Path) due to CleanupMode.ON_SUCCESS. Closes: #4282
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Prior to JUnit Jupiter 5.12, JRE-based conditions could only rely on predefined constants in the JRE enum. Furthermore, those constants are only updated as long as the particular JUnit Jupiter branch is supported. For example, once JUnit Jupiter 5.12 is released, there is no guarantee that the JRE enum constants will be updated in the 5.11.x branch. Consequently, users previously did not have the ability to enable or disable tests for Java versions released after a particular JUnit Jupiter branch was no longer supported. To address that, this commit introduces support for arbitrary Java versions in the JRE enum and related condition annotations. Users can now specify arbitrary Java versions via the `versions` attributes in @EnabledOnJre and @DisabledOnJre and via the `minVersion` and `maxVersion` attributes in @EnabledForJreRange and @DisabledForJreRange. Closes: #3930 Closes: #3931
See: #3931 Co-authored-by: Marc Philipp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )