add policy relay option in UI #136
Conversation
|
Is there a reason you did not also add Also, have you tested this? |
scripts/services/getConfig.ts
Outdated
| type: "boolean", | ||
| name: "Permitbaremultisig", | ||
| description: "Relay non-P2SH multisig", | ||
| default: false, |
There was a problem hiding this comment.
The default in Bitcoin Core is still 'true', not sure if it's ok to change this from the default
There was a problem hiding this comment.
No, given that this is Bitcoin Core, we think it appropriate to ship the same defaults as Core.
There was a problem hiding this comment.
I will change it if this is a problem, but know that P2MS is no longer used for payment purposes but almost exclusively to add arbitrary data to the chain in the worst possible way.
Also be aware that this relay policy applies only to new output created and not to the already existing one.
The developers in charge of Bitcoin seem to want to change the default value but unfortunately shitcoiners have sabotaged the PR to be able to continue to spam the chain.
There was a problem hiding this comment.
I understand the reasoning and on my personal node I'm definitely tweaking some of these settings! But as a developer and provider of the software you have to stay neutral unless absolutely necessary, and in that case it should be communicated and documented clearly why it's steering away from the defaults.
It's very good to provide options to the user, but it's the user themself who should decide if he wants to change options different than the consensus reached in the Core repository.
There was a problem hiding this comment.
It's good, the default value has been reset to true
|
@kn0wmad No none, that's why I just added it :) Yes, I was able to test and everything is functional, do I have to make a test report or something like that? |
Retropex
changed the title
datacarrier and permitbaremultisig option in UI
Retropex
force-pushed
the
official-repo
branch
from
d57b45d to
c7a2470
Compare
No, we just like to know that something has been tested before we take a look at it. We are still discussing our strategy in regard to these config options/alternate node installs at a higher level. We appreciate your patience while we figure out the best way forward. |
|
I just realized these options are not in the correct place in config. These are mempool options and should be listed under the Mempool section |
No description provided.