Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About and Contact are HTML files, not directories. #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jessp01
Copy link

@jessp01 jessp01 commented Feb 13, 2023

No description provided.

@f-lalonde
Copy link

Adding the .html is already taken care of by the scripts. This would either cause a problem or do nothing, in the best cases. This PR should be closed.

@jessp01
Copy link
Author

jessp01 commented Feb 21, 2023

@f-lalonde - can you please be more specific with regards to the script you are referring to? Maybe I've missed something but in my case, this resulted in a broken link in _site/*html.

@f-lalonde
Copy link

I was attempting to find in the files where this is happening, but you're right in that this is not part of the code : there is not "permalink : pretty" or anything similar in the code.

However, what I found out, is that pages hosted on GitHub Pages makes that happen for you : https://stackoverflow.com/questions/21244910/remove-html-extension-from-github-pages

Of course, if you are hosting your page elsewhere, it might not work. Hence, I rescind my previous comment : changing it does not seem to cause adverse problem, and may make the theme more universally applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants