Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Artifact and Underlords protobufs #1347

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Remove Artifact and Underlords protobufs #1347

merged 1 commit into from
Apr 7, 2024

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 4, 2024

These games are effectively dead.

https://store.steampowered.com/news/app/583950/view/3047218819080842820

If people still need these, they can generate these protos themselves.

@xPaw xPaw requested a review from psychonic April 4, 2024 10:38
@xPaw xPaw requested a review from voided April 7, 2024 09:24
voided
voided approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@voided voided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't feel too strongly about this, but perhaps we should generate those protos in NHA2 so at least the dissectors can keep working - but I have no idea how many people are looking at historical GC messages for these games.. Probably nobody?

@xPaw xPaw merged commit 03bc052 into master Apr 7, 2024
15 checks passed
@xPaw xPaw deleted the remove-underlords branch April 7, 2024 17:41
@xPaw xPaw added this to the 3.0.0 milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voided voided voided approved these changes

@psychonic psychonic psychonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @psychonic @voided