Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deterministic builds #1348

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Enable deterministic builds #1348

merged 1 commit into from
Apr 14, 2024

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 7, 2024

@JustArchi Archi do we need to add any other magic to improve the nuget?

@JustArchi
Copy link
Contributor

@xPaw I only set deterministic to true in csproj, and add -p:ContinuousIntegrationBuild=true when building within CI, so pretty much what you did, but I prefer to not rely on CI being set in the env of the runners.

@xPaw
Copy link
Member Author

xPaw commented Apr 7, 2024

CI env is documented here: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

It's also commonly available on other systems.

@xPaw xPaw merged commit 0e8937f into master Apr 14, 2024
15 checks passed
@xPaw xPaw deleted the deterministic branch April 14, 2024 08:06
@xPaw xPaw added this to the 3.0.0 milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants