Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @StefanTerdell, hope you are doing well.
First, this is a lot of work to maintain this package alone and it's great!
I saw that this issue #118 is being around a while without a fix, mainly because is not a critical error or something, but still pending.
Basically, we wanted to get rid of the warning logs for circular dependencies. At the moment, I didn't see any run time error while using it on super forms for svelte, but I wanted to remove the logs.
So, this is my contribution to this.
Changes:
parseDef
are now on single file. This way the parsers can import it without making a circular dependency.selectParser
: theselectParser
function to a single file. This require that the return strictlynull
if the selected parser is theparseDef
. Then, insideparseDef
, if the return is an strictly null (response === null
), then we consider that as call toparseDef
again.These changes make possible to solve the circular dependency. Maybe it's not the pretty solution, but it was the easier in my opinion.