Add Paginator to Bet #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
view_bets_and_pagination_commits
branch
from
405cde9
to
5db032c
Compare
ghost
changed the base branch from
view_bets_and_pagination_commits
to
display_all_bets
ghost
mentioned this pull request
ghost
changed the base branch from
display_all_bets
to
view_bets_and_pagination_commits
ghost
changed the base branch from
view_bets_and_pagination_commits
to
display_all_bets
Allow long strings for "context"
Adding pagination module that will have to be included in autoload_paths.
-Paginator module is responsible for calculating and rendering a pagination bar based on the passed parameters. -Added rspec for Paginator.
|
Rebased on top of #60 |
|
when visiting http://localhost:3000/bets I get a 500 |
-Add _blocks.html.erb view that renders page blocks; -Add _paginator.html.erb view that renders the pagination panel for the current page of a given Model.
ghost
force-pushed
the
view_bets_and_pagination_commits
branch
from
5a5299c
to
ed870d5
Compare
-Added the paginator helper method to index.html.erb for Bet that renders the pagination panel with given parameters; -Added display_bets partial that renders all the bets in the bets instance variable; -Added bet partial for Bet model;
|
@jacquesporveau Should be working now, thank you. |
ghost
force-pushed
the
view_bets_and_pagination_commits
branch
2 times, most recently
from
23b4f2a
to
a9f2557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal: https://www.pivotaltracker.com/story/show/140512959
Dependent on #60
-Added Paginator to Bet controller;
-Added Paginator to views for Bet model.