Feature: Support Multi-Step Paged Forms #18
Conversation
Adds ability to have multiple submit buttons/inputs. With this change (and a specific method of setup in the form templates), form data can be posted when navigating away from the current form step.
| @@ -226,21 +248,23 @@ public function run(array $properties = []) | |||
| $parameters['formaliciousTplNavigationItem'] = $this->getProperty('tplNavigationItem'); | |||
| $parameters['formaliciousTplNavigationWrapper'] = $this->getProperty('tplNavigationWrapper'); | |||
|
|
|||
| if ($currentStep <= 1) { | |||
There was a problem hiding this comment.
Why do you think we need to remove prevUrl if current step less or equal 1? There will be problem if somebody use this placeholder and it will disappear in new version.
Can you please describe this or return prevUrl for first step?
There was a problem hiding this comment.
I may be not accounting for a particular scenario, but why would you show a previous URL if you're on the first step?
There was a problem hiding this comment.
I agree with you. But if we delete this, we should change major version number I think. Because this broke backward compatibility. But maybe I'm wrong. I will ask somebody
There was a problem hiding this comment.
Ok, let me know. FYI, I verified that this change we're debating does not affect the functionality I'm introducing, so it can be reverted back if needed. If I remember, I made that change because the original line in the code caught my eye and didn't make sense to me.
There was a problem hiding this comment.
@smg6511 First of all, thank you for putting in the work!
I verified that this change we're debating does not affect the functionality I'm introducing, so it can be reverted back if needed.
Can you revert this part please, so we don't do any breaking changes?
Also could you add a section in the readme describing what you added and how that can be implemented? This will make it easier for other users to find out that it is possible and how they can achieve this.
| @@ -198,8 +198,30 @@ public function run(array $properties = []) | |||
| } else { | |||
| $hooks[] = 'redirect'; | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
@smg6511 Can you please format this multi line comment like this?
/**
* Sentence one.
* Sentence two.
*/
| A related change to FormIt's Request class is necessary for this additional functionality. | ||
| */ | ||
|
|
||
| # Default redirect destination |
There was a problem hiding this comment.
@smg6511 Can you make this a single line PHP comment like this?
/* Default redirect destination. */
| # Default redirect destination | ||
| $destination = $currentStep + 1; | ||
|
|
||
| # Check for alternate destination request |
There was a problem hiding this comment.
@smg6511 And like this:
/* Check for alternate destination request. */
|
|
||
| # Check for alternate destination request | ||
| if ($_POST) { | ||
| foreach ($_POST as $k => $v) { |
There was a problem hiding this comment.
@smg6511 Could you make the variable names minimum of three characters long?
foreach ($_POST as $key => $value) {
| $parameters['redirectTo'] = $this->getStepUrl([ | ||
| $this->getProperty('stepParam') => $currentStep + 1 | ||
| $this->getProperty('stepParam') => (int)$destination |
There was a problem hiding this comment.
@smg6511 Please add a whitespace after (int):
So:
(int) $destination
| } | ||
| $placeholders['submitValLast'] = $totalSteps; | ||
|
|
||
| # Suggest renaming this placeholder, as it makes its purpose more immediately clear |
There was a problem hiding this comment.
@smg6511 Can you format this like:
/* Suggest renaming this placeholder, as it makes its purpose more immediately clear. */
| $placeholders['submitValLast'] = $totalSteps; | ||
|
|
||
| # Suggest renaming this placeholder, as it makes its purpose more immediately clear | ||
| $placeholders['formAction'] = $totalSteps === 1 |
There was a problem hiding this comment.
@smg6511 Can you move the ; sign?
$placeholders['formAction'] = $totalSteps === 1
? $this->getStepUrl()
: $this->getStepUrl([$this->getProperty('stepParam') => $currentStep]);
Adds ability to have multiple submit buttons/inputs. With this change (and a specific method of setup in the form templates), form data can be posted when navigating away from the current form step.
Note: To use this feature, an addition/change to Formit is required as well (see PR 259 on Formit repo).