Fix analysis warnings

Vogen.sln.DotSettings

@@ -14,6 +14,7 @@
 	<s:String x:Key="/Default/CodeInspection/GeneratedCode/GeneratedFileMasks/=_002A_002Eg_002Ecs/@EntryIndexedValue">*.g.cs</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=BitwiseOperatorOnEnumWithoutFlags/@EntryIndexedValue">ERROR</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=CheckNamespace/@EntryIndexedValue">ERROR</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=CognitiveComplexity/@EntryIndexedValue">SUGGESTION</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertToPrimaryConstructor/@EntryIndexedValue">DO_NOT_SHOW</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=InvalidXmlDocComment/@EntryIndexedValue">ERROR</s:String>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=MemberCanBeMadeStatic_002ELocal/@EntryIndexedValue">ERROR</s:String>

src/Vogen/Extensions/IMethodSymbolExtensions.cs

@@ -15,6 +15,7 @@
 using System.Diagnostics;
 using System.Linq;
 using Microsoft.CodeAnalysis;
+// ReSharper disable ConditionIsAlwaysTrueOrFalse
 
 #if HAS_IOPERATION
 using System.Threading;
@@ -739,7 +740,7 @@ public static bool IsGetAwaiterFromAwaitablePattern(this IMethodSymbol? method,
                 return false;
             }
 
-            var returnType = method.ReturnType?.OriginalDefinition;
+            var returnType = method.ReturnType.OriginalDefinition;
             if (returnType is null)
             {
                 return false;

src/Vogen/Extensions/IPropertySymbolExtensions.cs

@@ -26,7 +26,7 @@ public static bool IsIsCompletedFromAwaiterPattern(
         {
             if (property is null
                 || !property.Name.Equals("IsCompleted", StringComparison.Ordinal)
-                || property.Type?.SpecialType != SpecialType.System_Boolean)
+                || property.Type.SpecialType != SpecialType.System_Boolean)
             {
                 return false;
             }

src/Vogen/Extensions/ReportDiagnosticExtensions.cs

@@ -8,18 +8,17 @@ namespace Microsoft.CodeAnalysis
 {
     internal static class ReportDiagnosticExtensions
     {
-        public static string ToAnalyzerConfigString(this ReportDiagnostic reportDiagnostic)
-        {
-            return reportDiagnostic switch
+        public static string ToAnalyzerConfigString(this ReportDiagnostic reportDiagnostic) =>
+            reportDiagnostic switch
             {
                 ReportDiagnostic.Error => "error",
                 ReportDiagnostic.Warn => "warning",
                 ReportDiagnostic.Info => "suggestion",
                 ReportDiagnostic.Hidden => "silent",
                 ReportDiagnostic.Suppress => "none",
+                ReportDiagnostic.Default => "none",
                 _ => throw new NotImplementedException(),
             };
-        }
 
         public static DiagnosticSeverity? ToDiagnosticSeverity(this ReportDiagnostic reportDiagnostic)
         {

src/Vogen/Extensions/SourceTextExtensions.cs

@@ -12,7 +12,7 @@ namespace Analyzer.Utilities.Extensions
     /// <summary>
     /// Class that contains extensions to <see cref="SourceText"/>.
     /// </summary>
-    internal static partial class SourceTextExtensions
+    internal static class SourceTextExtensions
     {
         /// <summary>
         /// Reads the <paramref name="text"/> contents into a stream and returns the result of calling the

src/Vogen/GenerateCodeForToString.cs

@@ -17,8 +17,6 @@ public static class GenerateCodeForToString
 
     private static string GenerateAnyHoistedToStringMethods(GenerationParameters generationParameters, bool isReadOnly)
     {
-        List<IMethodSymbol> formattableMethods = generationParameters.VogenKnownSymbols.IFormattable.GetJustMethods().ToList();
-
         var item = generationParameters.WorkItem; 
 
         INamedTypeSymbol primitiveSymbol = item.UnderlyingType;

src/Vogen/Generators/ClassGenerator.cs

@@ -18,12 +18,12 @@ public string Generate(GenerationParameters parameters)
         string underlyingBang = item.Nullable.BangForUnderlying;
         string wrapperBang = item.Nullable.BangForWrapper;
 
-        var code = Generate();
+        var code = GenerateCode();
 
         return item.Nullable.WrapBlock(code);
 
 
-    string Generate() => $@"
+    string GenerateCode() => $@"
 
 {Util.WriteStartNamespace(item.FullNamespace)}
     [global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage] 

src/Vogen/WriteDiagnostics.cs

@@ -73,7 +73,7 @@ private void ReportTargets(StringBuilder sb)
 
         foreach (var eachTarget in _targets)
         {
-            sb.AppendLine($"{eachTarget.VoSymbolInformation.ToString()}");
+            sb.AppendLine($"{eachTarget.VoSymbolInformation}");
         }
     }
 

tests/ConsumerTests/SerializationAndConversionTests/ClassVos/StringVoTests.cs

@@ -12,6 +12,11 @@
 using LinqToDB.Data;
 using LinqToDB.DataProvider.SQLite;
 using LinqToDB.Mapping;
+// ReSharper disable EqualExpressionComparison
+// ReSharper disable SuspiciousTypeConversion.Global
+// ReSharper disable ArrangeMethodOrOperatorBody
+// ReSharper disable TryCastAlwaysSucceeds
+// ReSharper disable NullableWarningSuppressionIsUsed
 
 namespace Vogen.IntegrationTests.SerializationAndConversionTests.ClassVos;
 
@@ -172,7 +177,7 @@ public void WhenEfCoreValueConverterUsesValueConverter()
     [Fact]
     public async Task WhenDapperValueConverterUsesValueConverter()
     {
-        using var connection = new SqliteConnection("DataSource=:memory:");
+        await using var connection = new SqliteConnection("DataSource=:memory:");
         await connection.OpenAsync();
 
         IEnumerable<DapperStringVo> results = await connection.QueryAsync<DapperStringVo>("SELECT 'foo!'");
@@ -215,7 +220,7 @@ public void TypeConverter_CanConvertToAndFrom(object value)
         var converter = TypeDescriptor.GetConverter(typeof(NoJsonStringVo));
         var id = converter.ConvertFrom(value);
         Assert.IsType<NoJsonStringVo>(id);
-        Assert.Equal(NoJsonStringVo.From(value!.ToString()), id);
+        Assert.Equal(NoJsonStringVo.From(value.ToString()!), id);
 
         var reconverted = converter.ConvertTo(id, value.GetType());
         Assert.Equal(value, reconverted);
@@ -244,13 +249,13 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
     public class EfCoreTestEntity
     {
-        public EfCoreStringVo Id { get; set; }
+        public EfCoreStringVo Id { get; init; }
     }
 
     public class LinqToDbTestEntity
     {
         [Column(DataType = DataType.VarChar)]
         [ValueConverter(ConverterType = typeof(LinqToDbStringVo.LinqToDbValueConverter))]
-        public LinqToDbStringVo Id { get; set; }
+        public LinqToDbStringVo Id { get; init; }
     }
 }

tests/Shared/ProjectBuilder.cs

@@ -22,7 +22,7 @@ namespace Shared;
 
 public record struct NuGetPackage(string PackageName, string Version, string PathPrefix);
 
-public sealed partial class ProjectBuilder
+public sealed class ProjectBuilder
 {
     public IList<DiagnosticAnalyzer> DiagnosticAnalyzers { get; } = new List<DiagnosticAnalyzer>();
     public IList<DiagnosticResult> ExpectedDiagnosticResults { get; } = new List<DiagnosticResult>();
@@ -160,6 +160,10 @@ private void AddNuGetReferences()
                 AddNuGetReference("Microsoft.OpenApi", "1.4.3.0", "lib/netstandard2.0/");
                 AddNuGetReference("MongoDB.Bson", "2.27.0", "lib/netstandard2.0");
                 break;
+            case null:
+                break;
+            default:
+                throw new ArgumentOutOfRangeException();
         }
 
         AddNuGetReference("System.Collections.Immutable", "1.5.0", "lib/netstandard2.0/");
@@ -227,6 +231,7 @@ async Task<string[]> Download()
                     var metadataReader = peFile.GetMetadataReader();
                     result.Add(eachDllNameAndPath);
                 }
+                // ReSharper disable once EmptyGeneralCatchClause
                 catch
                 {
                 }