feat: impl AsFd for PtyMaster (nix-rust#2355)

Fixes nix-rust#2354
SteveLauC · Apr 9, 2024 · 391a364 · 391a364
1 parent 0517893
commit 391a364
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/changelog/2355.added.md b/changelog/2355.added.md
@@ -0,0 +1 @@
+Added `impl AsFd for pty::PtyMaster`
diff --git a/src/pty.rs b/src/pty.rs
@@ -58,6 +58,12 @@ impl AsRawFd for PtyMaster {
     }
 }
 
+impl AsFd for PtyMaster {
+    fn as_fd(&self) -> BorrowedFd<'_> {
+        self.0.as_fd()
+    }
+}
+
 impl IntoRawFd for PtyMaster {
     fn into_raw_fd(self) -> RawFd {
         let fd = self.0;

diff --git a/test/test_pty.rs b/test/test_pty.rs
@@ -17,9 +17,10 @@ use nix::unistd::{pause, write};
 fn test_ptsname_equivalence() {
     let _m = crate::PTSNAME_MTX.lock();
 
-    // Open a new PTTY master
+    // Open a new PTY master
     let master_fd = posix_openpt(OFlag::O_RDWR).unwrap();
     assert!(master_fd.as_raw_fd() > 0);
+    assert!(master_fd.as_fd().as_raw_fd() == master_fd.as_raw_fd());
 
     // Get the name of the slave
     let slave_name = unsafe { ptsname(&master_fd) }.unwrap();