Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignoring $schema in resolved references #498

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

Stranger6667
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 96.75325% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (9c12d24) to head (dcdfa66).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
jsonschema/src/lib.rs 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   90.05%   90.01%   -0.05%     
==========================================
  Files          58       58              
  Lines        9866     9894      +28     
==========================================
+ Hits         8885     8906      +21     
- Misses        981      988       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #498 will degrade performances by 22.35%

Comparing dd/fix-metaschema (dcdfa66) with master (9c12d24)

Summary

⚡ 26 improvements
❌ 1 regressions
✅ 293 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/fix-metaschema Change
additional_properties_false [jsonschema/is_valid/valid] 360.6 ns 302.2 ns +19.3%
additional_properties_false foo1[jsonschema/is_valid/invalid] 391.7 ns 333.3 ns +17.5%
any_of 1[jsonschema/is_valid/valid] 669.4 ns 581.9 ns +15.04%
any_of_multiple_types foo[jsonschema/is_valid/valid] 853.6 ns 736.9 ns +15.83%
any_of_multiple_types null[jsonschema/is_valid/invalid] 854.4 ns 737.8 ns +15.81%
boolean_false 1[jsonschema/is_valid/invalid] 58.9 ns 29.7 ns +98.13%
const 1[jsonschema/is_valid/valid] 450.6 ns 392.2 ns +14.87%
const foo[jsonschema/is_valid/invalid] 298.6 ns 269.4 ns +10.82%
format_email [email protected][jsonschema/is_valid/valid] 595.6 ns 537.2 ns +10.86%
format_hostname not_a_valid_host_name[jsonschema/is_valid/invalid] 849.4 ns 761.9 ns +11.48%
items 123[jsonschema/validate/valid] 4.1 µs 5.2 µs -22.35%
maximum 3[jsonschema/is_valid/valid] 360 ns 301.7 ns +19.34%
maximum 5[jsonschema/is_valid/invalid] 360 ns 301.7 ns +19.34%
minimum 1[jsonschema/is_valid/invalid] 301.7 ns 272.5 ns +10.7%
minimum 5[jsonschema/is_valid/valid] 301.7 ns 272.5 ns +10.7%
multiple_of_integer 125[jsonschema/is_valid/valid] 951.1 ns 863.6 ns +10.13%
multiple_of_integer 212.4[jsonschema/is_valid/invalid] 453.3 ns 395 ns +14.77%
multiple_of_integer 212[jsonschema/is_valid/invalid] 898.3 ns 810.8 ns +10.79%
not 1[jsonschema/is_valid/valid] 633.6 ns 516.9 ns +22.57%
not null[jsonschema/is_valid/invalid] 633.6 ns 516.9 ns +22.57%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Stranger6667 Stranger6667 merged commit d27f9be into master Sep 10, 2024
32 of 33 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-metaschema branch September 10, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant