Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support integer-valued numbers in relevant validators #499

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Stranger6667
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 82.88770% with 32 lines in your changes missing coverage. Please review.

Project coverage is 89.98%. Comparing base (d27f9be) to head (9be29ab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
jsonschema/src/keywords/helpers.rs 27.27% 8 Missing ⚠️
jsonschema/src/keywords/max_items.rs 84.61% 4 Missing ⚠️
jsonschema/src/keywords/max_length.rs 84.61% 4 Missing ⚠️
jsonschema/src/keywords/max_properties.rs 84.61% 4 Missing ⚠️
jsonschema/src/keywords/min_items.rs 84.61% 4 Missing ⚠️
jsonschema/src/keywords/min_length.rs 84.61% 4 Missing ⚠️
jsonschema/src/keywords/min_properties.rs 84.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   90.01%   89.98%   -0.03%     
==========================================
  Files          58       58              
  Lines        9894    10057     +163     
==========================================
+ Hits         8906     9050     +144     
- Misses        988     1007      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #499 will degrade performances by 15.97%

Comparing dd/fix-integers (9be29ab) with master (d27f9be)

Summary

⚡ 3 improvements
❌ 5 regressions
✅ 312 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/fix-integers Change
fast jsonschema/is_valid/invalid 887.2 ns 799.7 ns +10.94%
additional_items_object 123foo[jsonschema/is_valid/valid] 1.1 µs 1.3 µs -15.97%
all_of 4[jsonschema/is_valid/valid] 829.7 ns 946.4 ns -12.33%
exclusive_maximum 2[jsonschema/is_valid/valid] 330.8 ns 272.5 ns +21.41%
exclusive_maximum 3[jsonschema/is_valid/invalid] 330.8 ns 272.5 ns +21.41%
format_email [email protected][jsonschema/is_valid/valid] 508.1 ns 566.4 ns -10.3%
one_of 3[jsonschema/is_valid/invalid] 921.1 ns 1,037.8 ns -11.24%
unique_items 11[jsonschema/is_valid/invalid] 618.3 ns 705.8 ns -12.4%

@Stranger6667 Stranger6667 merged commit 64b08ac into master Sep 10, 2024
32 of 33 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-integers branch September 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant