Autoformatting #21
Closed
Autoformatting #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
chore/formatting
branch
from
594d75f
to
dc18757
Compare
tsa96
force-pushed
the
chore/formatting
branch
from
dc18757
to
50dbab4
Compare
koerismo
requested changes
Aug 18, 2024
Comment on lines
6
to
+90
| PanoramaCastVoteNo: () => void; | ||
| PanoramaCastVoteYes: () => void; | ||
| RemoveStyle: (cls: string) => void; | ||
| RemoveStyleFromEachChild: (cls: string) => void; | ||
| ResetCarouselMouseWheelCounts: () => void; | ||
| ScrollPanelDown: () => void; | ||
| ScrollPanelLeft: () => void; | ||
| ScrollPanelRight: () => void; | ||
| ScrollPanelUp: () => void; | ||
| ScrollToBottom: () => void; | ||
| ScrollToTop: () => void; | ||
| SetCarouselSelectedChild: (panel: Panel) => void; | ||
| SetChildPanelsSelected: (selected: boolean) => void; | ||
| SetInputFocus: () => void; | ||
| SetPanelEnabled: (enabled: boolean) => void; | ||
| SetPanelSelected: (selected: boolean) => void; | ||
| SwitchStyle: (slot: string, cls: string) => void; | ||
| TogglePanelSelected: () => void; | ||
| ToggleStyle: (cls: string) => void; | ||
| TriggerStyle: (cls: string) => void; | ||
| UpdateFocusAndDirtyChildStyles: () => void; | ||
| } | ||
|
|
||
| interface GlobalEventNameMap { | ||
| 'AsyncEvent': (delay: duration, eventToFire: string) => void, | ||
| 'MainMenuResumeGame': () => void, | ||
| 'MainMenuPauseGame': () => void, | ||
| 'ShowPauseMenu': () => void, | ||
| 'HidePauseMenu': () => void, | ||
| 'ShowMainMenu': () => void, | ||
| 'HideMainMenu': () => void, | ||
| 'HudProcessInput': () => void, | ||
| 'HudThink': () => void, | ||
| 'ShowIntroMovie': () => void, | ||
| 'HideIntroMovie': () => void, | ||
| 'DemoPlaybackControl': (str: string, flt: float) => void, | ||
| 'Drawer_ExtendAndNavigateToTab': (tabid: string) => void, | ||
| 'Drawer_NavigateToTab': (tabid: string) => void, | ||
| 'Drawer_UpdateLobbyButton': (imgsrc: string, playercount: unknown) => void, | ||
| 'GameEventFired': (event: string) => void, | ||
| 'HideContentPanel': () => void, | ||
| 'LayoutReloaded': () => void, | ||
| 'MainMenuTabHidden': (tabid: string) => void, | ||
| 'MainMenuTabShown': (tabid: string) => void, | ||
| 'PageDown': () => void, | ||
| 'PageLeft': () => void, | ||
| 'PageRight': () => void, | ||
| 'PageUp': () => void, | ||
| 'PanoramaGameTimeJumpEvent': (time: duration) => void, | ||
| 'ReloadBackground': () => void, | ||
| 'ScrollDown': () => void, | ||
| 'ScrollLeft': () => void, | ||
| 'ScrollRight': () => void, | ||
| 'ScrollUp': () => void, | ||
| 'SettingsNavigateToPanel': (category: string, panel: Panel) => void, | ||
| 'ShowCenterPrintText': (message: string, priority: unknown) => void, | ||
| 'ShowContentPanel': () => void, | ||
| 'ShowVoteContextMenu': () => void, | ||
| 'StaticHudMenu_EntrySelected': (panel: Panel) => void, | ||
| 'UnloadLoadingScreenAndReinit': () => void, | ||
| 'AchievementInfoLoaded': () => void, | ||
| 'AchievementEarned': (player_index: number, achievement_index: number) => void, | ||
| AsyncEvent: (delay: duration, eventToFire: string) => void; | ||
| MainMenuResumeGame: () => void; | ||
| MainMenuPauseGame: () => void; | ||
| ShowPauseMenu: () => void; | ||
| HidePauseMenu: () => void; | ||
| ShowMainMenu: () => void; | ||
| HideMainMenu: () => void; | ||
| HudProcessInput: () => void; | ||
| HudThink: () => void; | ||
| ShowIntroMovie: () => void; | ||
| HideIntroMovie: () => void; | ||
| DemoPlaybackControl: (str: string, flt: float) => void; | ||
| Drawer_ExtendAndNavigateToTab: (tabid: string) => void; | ||
| Drawer_NavigateToTab: (tabid: string) => void; | ||
| Drawer_UpdateLobbyButton: (imgsrc: string, playercount: unknown) => void; | ||
| GameEventFired: (event: string) => void; | ||
| HideContentPanel: () => void; | ||
| LayoutReloaded: () => void; | ||
| MainMenuTabHidden: (tabid: string) => void; | ||
| MainMenuTabShown: (tabid: string) => void; | ||
| PageDown: () => void; | ||
| PageLeft: () => void; | ||
| PageRight: () => void; | ||
| PageUp: () => void; | ||
| PanoramaGameTimeJumpEvent: (time: duration) => void; | ||
| ReloadBackground: () => void; | ||
| ScrollDown: () => void; | ||
| ScrollLeft: () => void; | ||
| ScrollRight: () => void; | ||
| ScrollUp: () => void; | ||
| SettingsNavigateToPanel: (category: string, panel: Panel) => void; | ||
| ShowCenterPrintText: (message: string, priority: unknown) => void; | ||
| ShowContentPanel: () => void; | ||
| ShowVoteContextMenu: () => void; | ||
| StaticHudMenu_EntrySelected: (panel: Panel) => void; | ||
| UnloadLoadingScreenAndReinit: () => void; | ||
| AchievementInfoLoaded: () => void; | ||
| AchievementEarned: (player_index: number, achievement_index: number) => void; |
There was a problem hiding this comment.
is there anything we can do so it doesn't totally fuck up the formatting of this file?
There was a problem hiding this comment.
No, prettier will always get rid of indentation like this, personally I prefer it prettier's way, find it easier to read and edit, if you really can't stand it we wouldn't be able to use prettier (happy to discuss that).
p2ce/achievements.d.ts
Outdated
Comment on lines
3
to
10
| name: string; // Name of the achievement | ||
| index: number; // Index of the achievement (for use with the API) | ||
| achieved: boolean; // True if this has been achieved | ||
| available: boolean; // True if this is available | ||
| hide_until_achieved: boolean; // True if this is a "hidden" achievement. It should not be displayed in its full glory until achieved | ||
| name: string; // Name of the achievement | ||
| index: number; // Index of the achievement (for use with the API) | ||
| achieved: boolean; // True if this has been achieved | ||
| available: boolean; // True if this is available | ||
| hide_until_achieved: boolean; // True if this is a "hidden" achievement. It should not be displayed in its full glory until achieved | ||
| flags: number; | ||
| count: number; // Current count, if a stat is involved with this achievement. The achievement is granted when count >= goal | ||
| goal: number; // Stat goal for this achievement | ||
| count: number; // Current count, if a stat is involved with this achievement. The achievement is granted when count >= goal | ||
| goal: number; // Stat goal for this achievement | ||
| } |
There was a problem hiding this comment.
not a huge fan of what it's doing with the comments here (and elsewhere), they were somewhat easier to read as they were.
There was a problem hiding this comment.
Oh yeah, I can convert to single line /** */ comments.
koerismo
approved these changes
Aug 23, 2024
|
Closing as per internal discussion |
|
Will leave branch in case we change our mind in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did this a few weeks ago and forgot to PR. Adds Prettier autoformatting, as an npm script and a CI job.
Don't love making this an npm package, but devs won't necessarily need to run
npm installfor any of this if they have a Prettier extension for their editor and use it. But it's there if desired, and is needed for CI job anyway.