Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notifications with Continue watching #423

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Jan 17, 2023

No description provided.

src/constants.rs Outdated
@@ -27,6 +29,7 @@ pub const GENRES_LINK_CATEGORY: &str = "Genres";
pub const CINEMETA_TOP_CATALOG_ID: &str = "top";
pub const IMDB_TITLE_PATH: &str = "title";
pub const YOUTUBE_ADDON_ID_PREFIX: &str = "yt_id:";
pub const INTRO_FEED_ID: &str = "feed-intro";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this.

src/constants.rs Outdated
Comment on lines 53 to 54
/// Meta hub url used to show background images for Notifications.
pub static ref METAHUB_URL: Url = Url::parse("https://images.metahub.space").expect("METAHUB_URL parse failed");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, since we shouldn't hardcode the url for addons but leave them to provide the poster.

@elpiel elpiel changed the title feat: Notifications impl from JS worker feat: Notifications with Continue watching Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant