-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notifications with Continue watching #423
Draft
elpiel
wants to merge
6
commits into
development
Choose a base branch
from
continue-watching
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
for new episodes Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
continue-watching
branch
from
January 21, 2023 10:13
bbe530b
to
170a459
Compare
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
commented
Jan 23, 2023
src/constants.rs
Outdated
@@ -27,6 +29,7 @@ pub const GENRES_LINK_CATEGORY: &str = "Genres"; | |||
pub const CINEMETA_TOP_CATALOG_ID: &str = "top"; | |||
pub const IMDB_TITLE_PATH: &str = "title"; | |||
pub const YOUTUBE_ADDON_ID_PREFIX: &str = "yt_id:"; | |||
pub const INTRO_FEED_ID: &str = "feed-intro"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove this.
src/constants.rs
Outdated
Comment on lines
53
to
54
/// Meta hub url used to show background images for Notifications. | ||
pub static ref METAHUB_URL: Url = Url::parse("https://images.metahub.space").expect("METAHUB_URL parse failed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, since we shouldn't hardcode the url for addons but leave them to provide the poster.
elpiel
changed the title
feat: Notifications impl from JS worker
feat: Notifications with Continue watching
Jan 24, 2023
…fications` Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.