feat: library item progress #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
requested changes
Jun 5, 2023
elpiel
reviewed
Jun 16, 2023
src/types/library/library_item.rs
Outdated
| #[inline] | ||
| pub fn progress(&self) -> f64 { | ||
| if self.state.time_offset > 0 && self.state.duration > 0 { | ||
| self.state.time_offset as f64 / self.state.duration as f64 |
There was a problem hiding this comment.
Depending on what values we expect here, for large-enough values (like u64::MAX) we might get into problems when we use as f64:
Do we have to worry about such large values?
If we do need, then I would suggest using Ratio:
https://docs.rs/num/latest/num/rational/struct.Ratio.html#impl-ToPrimitive
And then try to make a f64 out of it:
https://docs.rs/num/latest/num/trait.ToPrimitive.html#method.to_f64
…into feat/library-item-stream-id
|
@tymmesyde Should we use the new stream bucket now? |
Yes, we should. |
…into feat/library-item-stream-id
…into feat/library-item-stream-id
…into feat/library-item-stream-id
…into feat/library-item-stream-id
tymmesyde
force-pushed
the
feat/library-item-stream-id
branch
from
ac2be00
to
37c59c5
Compare
elpiel
approved these changes
Sep 13, 2023
elpiel
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
stream_idto LibraryItemStateRelated Stremio/stremio-web#383
core-webchanges: feat(serialize_meta_details): return stream and video progress stremio-core-web#51