Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing classes to track issues #26

Merged
merged 7 commits into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ __pycache__
/.token
/antlr-*.jar
.DS_Store
.coverage
37 changes: 37 additions & 0 deletions pylasu/parsing/results.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
from dataclasses import dataclass
from typing import List

from antlr4 import ParserRuleContext, Token

from pylasu.model import Source
from pylasu.validation.validation import WithIssues, IssueType, Issue


@dataclass
class FirstStageResult(WithIssues):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FirstStageResult should have an issues: List[Issue] = default_factory(list) property to avoid a dataclass missing field error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the issues list here would not be required if following the comment concerning WithIssues below

parse_tree: ParserRuleContext


@dataclass
class LexingResult(WithIssues):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as FirstStageResult and every other WithIssues subclass

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the issues list here would not be required if following the comment concerning WithIssues below

tokens: List[Token]


@dataclass
class IssuesErrorListener:
"""This Error Listener should be used with ANTLR lexers and parsers to capture issues"""
type: IssueType
source: Source
issues: WithIssues

def syntaxError(self, recognizer, offendingSymbol, line, column, msg, e):
self.issues.append(Issue(type=self.type, message=msg))

def reportAmbiguity(self, recognizer, dfa, startIndex, stopIndex, exact, ambigAlts, configs):
pass

def reportAttemptingFullContext(self, recognizer, dfa, startIndex, stopIndex, conflictingAlts, configs):
pass

def reportContextSensitivity(self, recognizer, dfa, startIndex, stopIndex, prediction, configs):
pass
9 changes: 7 additions & 2 deletions pylasu/validation/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ def semantic(message: str, severity: IssueSeverity = IssueSeverity.ERROR, positi


@dataclass
class Result:
class WithIssues:
"""Many classes have the necessity of tracking issues"""
issues: List[Issue] = field(default_factory=list, init=False)


@dataclass
class Result(WithIssues):
root: Node
issues: List[Issue] = field(default_factory=list)