Import from Lionweb models not exported from Kolasu #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftomassetti
reviewed
May 13, 2024
src/interop/lionweb.ts
Outdated
| // TODO we assume that: | ||
| // 1) we're importing a StarLasu AST | ||
| // 2) containments in a StarLasu AST are either AST nodes or internal StarLasu objects like the position | ||
| // TODO is it possible in Lionweb to have a Containment that's not a concept? |
There was a problem hiding this comment.
Yes: it could be a ConceptInterface
There was a problem hiding this comment.
Ok, it makes sense to support that as well.
|
I am not sure I understand the code, but I cannot find anything obviously wrong with it. Maybe adding a test would make the resolution more obvious, but I would not block this PR because of that. |
ftomassetti
approved these changes
May 13, 2024
|
I've kept the existing tests and they still pass. I've manually modified the FS language so that no concept inherits from ASTNode, that should be sufficient to verify we can actually handle those languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #66