Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test matrix & release 1.0.6 #61

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Conversation

mtakeda15
Copy link

@mtakeda15 mtakeda15 commented Jan 17, 2025

What?

update test matrix
release verison 1.0.6

@mtakeda15 mtakeda15 changed the title update test matrix update test matrix & release 1.0.6 Jan 17, 2025
@mtakeda15
Copy link
Author

@valerauko
以下でコメント頂いていた件の対応です。
scimaenaga 自体が現在 rails < 7.2 を指定しているので、テストはrails 7.1までとしました。
#60 (comment)

また、この内容でversion 1.0.6をリリースしてしまいたい。

@mtakeda15 mtakeda15 requested a review from valerauko January 17, 2025 16:37
@mtakeda15 mtakeda15 self-assigned this Jan 17, 2025
@mtakeda15 mtakeda15 marked this pull request as ready for review January 17, 2025 16:37
Comment on lines 66 to 70
- 7.0.4.3
# 2023-10-05 releases
- 7.1
# 2024-12-10 releases
- 7.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test against last two releases from supported rails versions

てなってるけど、そのままで間違いないなら以下だと思う

- 7.0.7.2
- 7.0.8.7
- 7.1.4.2
- 7.1.5.1
- 7.2.1.2
- 7.2.2.1

間違いないかな?多すぎる?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たしかに。そうしましょう。

ruby: 3.2.6
- rails: 7.0.8.7
ruby: 3.3.7
# rails 7.2 requires ruby >= 3.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あれ?3.1以上なら3.0系はだめじゃない?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なのでrails 7.2 系のテストでは ruby 3.0系を除外しています!

@mtakeda15 mtakeda15 merged commit 4d36365 into master Jan 21, 2025
23 checks passed
@mtakeda15 mtakeda15 deleted the feature/update-test-matrix branch January 21, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants