Skip to content

Commit

Permalink
Update code for Crystal 0.36.0
Browse files Browse the repository at this point in the history
Rename `HTTPClient@socket` to `HTTPClient@io`, see
crystal-lang/crystal#9543.

Rename `URI#full_path` to `URI#request_target`, see
crystal-lang/crystal#10099.
  • Loading branch information
saltycrys authored and FireMasterK committed Feb 4, 2021
1 parent 4403643 commit 63f858a
Show file tree
Hide file tree
Showing 14 changed files with 41 additions and 41 deletions.
30 changes: 15 additions & 15 deletions src/invidious.cr
Original file line number Diff line number Diff line change
Expand Up @@ -1428,9 +1428,9 @@ get "/feed/playlist/:plid" do |env|
node.attributes.each do |attribute|
case attribute.name
when "url", "href"
full_path = URI.parse(node[attribute.name]).full_path
query_string_opt = full_path.starts_with?("/watch?v=") ? "&#{params}" : ""
node[attribute.name] = "#{HOST_URL}#{full_path}#{query_string_opt}"
request_target = URI.parse(node[attribute.name]).request_target
query_string_opt = request_target.starts_with?("/watch?v=") ? "&#{params}" : ""
node[attribute.name] = "#{HOST_URL}#{request_target}#{query_string_opt}"
else nil # Skip
end
end
Expand All @@ -1439,7 +1439,7 @@ get "/feed/playlist/:plid" do |env|
document = document.to_xml(options: XML::SaveOptions::NO_DECL)

document.scan(/<uri>(?<url>[^<]+)<\/uri>/).each do |match|
content = "#{HOST_URL}#{URI.parse(match["url"]).full_path}"
content = "#{HOST_URL}#{URI.parse(match["url"]).request_target}"
document = document.gsub(match[0], "<uri>#{content}</uri>")
end

Expand Down Expand Up @@ -1634,7 +1634,7 @@ end

get "/attribution_link" do |env|
if query = env.params.query["u"]?
url = URI.parse(query).full_path
url = URI.parse(query).request_target
else
url = "/"
end
Expand Down Expand Up @@ -1978,7 +1978,7 @@ get "/api/v1/captions/:id" do |env|
caption = caption[0]
end

url = URI.parse("#{caption.baseUrl}&tlang=#{tlang}").full_path
url = URI.parse("#{caption.baseUrl}&tlang=#{tlang}").request_target

# Auto-generated captions often have cues that aren't aligned properly with the video,
# as well as some other markup that makes it cumbersome, so we try to fix that here
Expand Down Expand Up @@ -3184,15 +3184,15 @@ get "/api/manifest/dash/id/:id" do |env|
end

if dashmpd = video.dash_manifest_url
manifest = YT_POOL.client &.get(URI.parse(dashmpd).full_path).body
manifest = YT_POOL.client &.get(URI.parse(dashmpd).request_target).body

manifest = manifest.gsub(/<BaseURL>[^<]+<\/BaseURL>/) do |baseurl|
url = baseurl.lchop("<BaseURL>")
url = url.rchop("</BaseURL>")

if local
uri = URI.parse(url)
url = "#{uri.full_path}host/#{uri.host}/"
url = "#{uri.request_target}host/#{uri.host}/"
end

"<BaseURL>#{url}</BaseURL>"
Expand All @@ -3205,7 +3205,7 @@ get "/api/manifest/dash/id/:id" do |env|

if local
adaptive_fmts.each do |fmt|
fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).full_path)
fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).request_target)
end
end

Expand Down Expand Up @@ -3403,7 +3403,7 @@ get "/latest_version" do |env|
next
end

url = URI.parse(url).full_path.not_nil! if local
url = URI.parse(url).request_target.not_nil! if local
url = "#{url}&title=#{title}" if title

env.redirect url
Expand Down Expand Up @@ -3515,7 +3515,7 @@ get "/videoplayback" do |env|
client = make_client(URI.parse(new_host), region)
end

url = "#{location.full_path}&host=#{location.host}#{region ? "&region=#{region}" : ""}"
url = "#{location.request_target}&host=#{location.host}#{region ? "&region=#{region}" : ""}"
else
break
end
Expand Down Expand Up @@ -3555,7 +3555,7 @@ get "/videoplayback" do |env|

if location = response.headers["Location"]?
location = URI.parse(location)
location = "#{location.full_path}&host=#{location.host}"
location = "#{location.request_target}&host=#{location.host}"

if region
location += "&region=#{region}"
Expand Down Expand Up @@ -3619,7 +3619,7 @@ get "/videoplayback" do |env|

if location = response.headers["Location"]?
location = URI.parse(location)
location = "#{location.full_path}&host=#{location.host}#{region ? "&region=#{region}" : ""}"
location = "#{location.request_target}&host=#{location.host}#{region ? "&region=#{region}" : ""}"

env.redirect location
break
Expand Down Expand Up @@ -3859,7 +3859,7 @@ end
get "/watch_videos" do |env|
response = YT_POOL.client &.get(env.request.resource)
if url = response.headers["Location"]?
url = URI.parse(url).full_path
url = URI.parse(url).request_target
next env.redirect url
end

Expand All @@ -3874,7 +3874,7 @@ error 404 do |env|
response = YT_POOL.client &.get("/#{item}")

if response.status_code == 301
response = YT_POOL.client &.get(URI.parse(response.headers["Location"]).full_path)
response = YT_POOL.client &.get(URI.parse(response.headers["Location"]).request_target)
end

if response.body.empty?
Expand Down
10 changes: 5 additions & 5 deletions src/invidious/comments.cr
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def template_youtube_comments(comments, locale, thin_mode)
end

if !thin_mode
author_thumbnail = "/ggpht#{URI.parse(child["authorThumbnails"][-1]["url"].as_s).full_path}"
author_thumbnail = "/ggpht#{URI.parse(child["authorThumbnails"][-1]["url"].as_s).request_target}"
else
author_thumbnail = ""
end
Expand Down Expand Up @@ -322,7 +322,7 @@ def template_youtube_comments(comments, locale, thin_mode)
html << <<-END_HTML
<div class="pure-g">
<div class="pure-u-1 pure-u-md-1-2">
<img style="width:100%" src="/ggpht#{URI.parse(attachment["url"].as_s).full_path}">
<img style="width:100%" src="/ggpht#{URI.parse(attachment["url"].as_s).request_target}">
</div>
</div>
END_HTML
Expand Down Expand Up @@ -375,7 +375,7 @@ def template_youtube_comments(comments, locale, thin_mode)

if child["creatorHeart"]?
if !thin_mode
creator_thumbnail = "/ggpht#{URI.parse(child["creatorHeart"]["creatorThumbnail"].as_s).full_path}"
creator_thumbnail = "/ggpht#{URI.parse(child["creatorHeart"]["creatorThumbnail"].as_s).request_target}"
else
creator_thumbnail = ""
end
Expand Down Expand Up @@ -473,7 +473,7 @@ def replace_links(html)
params = HTTP::Params.parse(url.query.not_nil!)
anchor["href"] = params["q"]?
else
anchor["href"] = url.full_path
anchor["href"] = url.request_target
end
elsif url.to_s == "#"
begin
Expand Down Expand Up @@ -544,7 +544,7 @@ def content_to_comment_html(content)
if url.path == "/redirect"
url = HTTP::Params.parse(url.query.not_nil!)["q"]
else
url = url.full_path
url = url.request_target
end
end

Expand Down
6 changes: 3 additions & 3 deletions src/invidious/helpers/proxy.cr
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ end
class HTTPClient < HTTP::Client
def set_proxy(proxy : HTTPProxy)
begin
@socket = proxy.open(host: @host, port: @port, tls: @tls, connection_options: proxy_connection_options)
@io = proxy.open(host: @host, port: @port, tls: @tls, connection_options: proxy_connection_options)
rescue IO::Error
@socket = nil
@io = nil
end
end

def unset_proxy
@socket = nil
@io = nil
end

def proxy_connection_options
Expand Down
2 changes: 1 addition & 1 deletion src/invidious/helpers/utils.cr
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def get_referer(env, fallback = "/", unroll = true)
end
end

referer = referer.full_path
referer = referer.request_target
referer = "/" + referer.gsub(/[^\/?@&%=\-_.0-9a-zA-Z]/, "").lstrip("/\\")

if referer == env.request.path
Expand Down
2 changes: 1 addition & 1 deletion src/invidious/jobs/bypass_captcha_job.cr
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class Invidious::Jobs::BypassCaptchaJob < Invidious::Jobs::BaseJob
elsif response.headers["Location"]?.try &.includes?("/sorry/index")
location = response.headers["Location"].try { |u| URI.parse(u) }
headers = HTTP::Headers{":authority" => location.host.not_nil!}
response = YT_POOL.client &.get(location.full_path, headers)
response = YT_POOL.client &.get(location.request_target, headers)

html = XML.parse_html(response.body)
form = html.xpath_node(%(//form[@action="index"])).not_nil!
Expand Down
4 changes: 2 additions & 2 deletions src/invidious/routes/embed.cr
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ class Invidious::Routes::Embed < Invidious::Routes::BaseRoute
adaptive_fmts = video.adaptive_fmts

if params.local
fmt_stream.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).full_path) }
adaptive_fmts.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).full_path) }
fmt_stream.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).request_target) }
adaptive_fmts.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).request_target) }
end

video_streams = video.video_streams
Expand Down
2 changes: 1 addition & 1 deletion src/invidious/routes/login.cr
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ class Invidious::Routes::Login < Invidious::Routes::BaseRoute
traceback << "Unhandled dialog /b/0/SmsAuthInterstitial."
end

login = client.get(location.full_path, headers)
login = client.get(location.request_target, headers)

headers = login.cookies.add_request_headers(headers)
location = login.headers["Location"]?.try { |u| URI.parse(u) }
Expand Down
4 changes: 2 additions & 2 deletions src/invidious/routes/watch.cr
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ class Invidious::Routes::Watch < Invidious::Routes::BaseRoute
adaptive_fmts = video.adaptive_fmts

if params.local
fmt_stream.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).full_path) }
adaptive_fmts.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).full_path) }
fmt_stream.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).request_target) }
adaptive_fmts.each { |fmt| fmt["url"] = JSON::Any.new(URI.parse(fmt["url"].as_s).request_target) }
end

video_streams = video.video_streams
Expand Down
4 changes: 2 additions & 2 deletions src/invidious/views/channel.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<% if channel.banner %>
<div class="h-box">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).full_path %>">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).request_target %>">
</div>

<div class="h-box">
Expand All @@ -16,7 +16,7 @@
<div class="pure-g h-box">
<div class="pure-u-2-3">
<div class="channel-profile">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).full_path %>">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).request_target %>">
<span><%= channel.author %></span>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/invidious/views/community.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<% if channel.banner %>
<div class="h-box">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).full_path %>">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).request_target %>">
</div>

<div class="h-box">
Expand All @@ -15,7 +15,7 @@
<div class="pure-g h-box">
<div class="pure-u-2-3">
<div class="channel-profile">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).full_path %>">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).request_target %>">
<span><%= channel.author %></span>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/invidious/views/components/item.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<a style="width:100%" href="/channel/<%= item.ucid %>">
<% if !env.get("preferences").as(Preferences).thin_mode %>
<center>
<img style="width:56.25%" src="/ggpht<%= URI.parse(item.author_thumbnail).full_path %>"/>
<img style="width:56.25%" src="/ggpht<%= URI.parse(item.author_thumbnail).request_target %>"/>
</center>
<% end %>
<p><%= item.author %></p>
Expand All @@ -15,15 +15,15 @@
<h5><%= item.description_html %></h5>
<% when SearchPlaylist, InvidiousPlaylist %>
<% if item.id.starts_with? "RD" %>
<% url = "/mix?list=#{item.id}&continuation=#{URI.parse(item.thumbnail || "/vi/-----------").full_path.split("/")[2]}" %>
<% url = "/mix?list=#{item.id}&continuation=#{URI.parse(item.thumbnail || "/vi/-----------").request_target.split("/")[2]}" %>
<% else %>
<% url = "/playlist?list=#{item.id}" %>
<% end %>

<a style="width:100%" href="<%= url %>">
<% if !env.get("preferences").as(Preferences).thin_mode %>
<div class="thumbnail">
<img class="thumbnail" src="<%= URI.parse(item.thumbnail || "/").full_path %>"/>
<img class="thumbnail" src="<%= URI.parse(item.thumbnail || "/").request_target %>"/>
<p class="length"><%= number_with_separator(item.video_count) %> videos</p>
</div>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion src/invidious/views/components/player.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<% if params.video_loop %>loop<% end %>
<% if params.controls %>controls<% end %>>
<% if (hlsvp = video.hls_manifest_url) && !CONFIG.disabled?("livestreams") %>
<source src="<%= URI.parse(hlsvp).full_path %><% if params.local %>?local=true<% end %>" type="application/x-mpegURL" label="livestream">
<source src="<%= URI.parse(hlsvp).request_target %><% if params.local %>?local=true<% end %>" type="application/x-mpegURL" label="livestream">
<% else %>
<% if params.listen %>
<% audio_streams.each_with_index do |fmt, i| %>
Expand Down
4 changes: 2 additions & 2 deletions src/invidious/views/playlists.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<% if channel.banner %>
<div class="h-box">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).full_path %>">
<img style="width:100%" src="/ggpht<%= URI.parse(channel.banner.not_nil!.gsub("=w1060-", "=w1280-")).request_target %>">
</div>

<div class="h-box">
Expand All @@ -15,7 +15,7 @@
<div class="pure-g h-box">
<div class="pure-u-2-3">
<div class="channel-profile">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).full_path %>">
<img src="/ggpht<%= URI.parse(channel.author_thumbnail).request_target %>">
<span><%= channel.author %></span>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/invidious/views/watch.ecr
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
<a href="/channel/<%= video.ucid %>" style="display:block;width:fit-content;width:-moz-fit-content">
<div class="channel-profile">
<% if !video.author_thumbnail.empty? %>
<img src="/ggpht<%= URI.parse(video.author_thumbnail).full_path %>">
<img src="/ggpht<%= URI.parse(video.author_thumbnail).request_target %>">
<% end %>
<span id="channel-name"><%= video.author %></span>
</div>
Expand Down

0 comments on commit 63f858a

Please sign in to comment.