[pull] master from iv-org:master #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
SamantazFox
force-pushed
the
master
branch
2 times, most recently
from
d69e8f1
to
4fcd096
Compare
"Temporary" fix, until a better and more permanent solution is found. Closes issue 4584
Videos of a playlist cataloged as podcast are called episodes therefore Invidious was not able to find `video` in the `text` value inside the stats array.
Invidious assumes that every playlist will have at least one video because it needs to check for the `index` key. So if there is no videos on a playlist, there is no `index` key and Invidious throws `Index out of bounds`
Co-authored-by: Samantaz Fox <[email protected]>
The HTTP::Client created via `make_client` is affected by the force_resolve configuration option. However, api.invidious.io does not support ipv6 and as such any request with ipv6 to api.invidious.io will instead raise. Directly calling the HTTP::Client will ignore the force_resolve option allowing requests to go through ipv4 when needed.
Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Jeff Huang <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: 大王叫我来巡山 <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: NEXI <[email protected]>
Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Petter Reinholdtsen <[email protected]>
Co-authored-by: Samantaz Fox <[email protected]>
The automatic instance redirection implemented in #1940 fetches a new list of instances each time someone queries the /redirect endpoint. This is extremely inefficient... This PR optimizes all that into a background job that only fetches a single list every 30 minutes. This should performance quite a bit. No related issue was opened.
This PR adds a configuration option to control the preloading of video data on page load with the HTML5 'preload'[1] attribute on the `<video>` element. The option is enabled by default, meaning that the `preload` attribute's value will be 'auto'. If users want to prevent preloading of video data, they can disable the option, which will set the attribute value to 'none'. [1](https://www.w3schools.com/tags/att_video_preload.asp) Closes issue 4110
This PR adds the error message to the "search on Github" link located on the crash page, so that the search bar is already filled and the issues filtered when the user opens said link. As seen with #4584 and other critical problems, duplicate issues end up unnecessarily flooding the issue reports. While this change won't entirely stop this behavior, this will help the user to easily identify if the error they have received has been reported yet and discourage them from creating a duplicate (hopefully...). No associated issue was open
Closes issue 4837
This PR makes it possible to display badges in the search results for third party Invidious applications (ex: FreeTube) See also: FreeTubeApp/FreeTube#5590 No related issue
In Crystal, handling multi-byte sequences in UTF-8 requires understanding that slicing by bytes can lead to invalid sequences if the slicing isn't aligned with character boundaries. In this case, attempting to slice a string by bytes can cut through multi-byte UTF-8 sequences, leading to invalid sequences. To avoid this, strings should be sliced based on characters rather than bytes. Fixes issue 4886
No related issue
Use the proper URL argument when transforming youtu.be URLs to their youtube.com equivalents. Thanks to Tuhgy on the fediverse for reporting this! No related issue
Signed-off-by: Fijxu <[email protected]>
update the mocks with the latest updated data
Partially addresses issue 301
Theoretically this should improve memory usage and performance by quite a bit as we aren't creating a new HTTP::Client and in a turn a new connection for every image we request from YouTube. Closes issue 4009
The fix basically enlarges the hoverable area in order to avoid getting the menu closed if the mouse isn't moved fast enough. Video of the fix: https://www.loom.com/share/36494a3653984650aea3eaa2af276a35 Closes issue 4749
Fijxu have been using it for more than 3 weeks on their instance and they report that it works really well. This only works if 'inv_sig_helper' itself crashes and restarts (via systemd or docker restart policy) but it will not work if 'inv_sig_helper' hangs and stops responding to invidious (but this is an issue with 'inv_sig_helper', not Invidious). Closes issue 4926
This PR add an MT option to the Makefile. When make is invoked with 'MT=1', the 'preview_mt' flag is passed to the Crystal compiler. It doesn't mean that invidious fully supports multi-threading, but at least it provides an easy way for trying that out. No related issue.
…4995) I encountered a wild [warn] i18n: Missing translation key "Filipino (auto-generated)" while browsing videos on the test instance. No related issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )