Adding an increase & decrease rate for the button, fixing demo and project settings #4
Conversation
…Adding increase and decrease property. Updating project settings to avoid conflicts.
|
@kmiloaguilar, Thanks for your work. Could you please separate the core implementation? There're lot of unreleated diffs. |
|
@devxoul Can you me more specific? How do you prefer to separate with core implementation? For now the new properties if they are not set it will still do the same. The Pod folder I removed all since not required over here. And the Demo is the only one. I could create a separate buttons for the demo if that is the separation you want. |
|
Also the Demo was failing when doing a clean install, mostly because of the Pods. Adding instructions to run pod install can help too. |
|
I mean, 1 PR (or 1 commit) should have 1 implementation. Your PR has only a commit that contains 'Adding an increase & decrease rate for the button' and 'fixing demo and project settings'. |
|
ok so you want 1 PR for adding new properties to the button and another PR to fix the demo and project settings ? |
|
@kmiloaguilar Exactly! Thanks for your understanding to keep commit & PR log clean 😄 |
No description provided.