-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/springboot: alter "list tickets" SQL query on the fly #408
Draft
srenatus
wants to merge
1
commit into
main
Choose a base branch
from
sr/experiment/springboot-altering-raw-sql
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 34 additions & 4 deletions
38
...r/springboot/src/main/java/com/styra/tickethub_springboot/dao/model/TicketRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,42 @@ | ||
package com.styra.tickethub_springboot.dao.model; | ||
|
||
import com.styra.tickethub_springboot.App; | ||
import java.util.List; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import org.springframework.data.domain.Sort; | ||
import org.springframework.data.jpa.repository.JpaRepository; | ||
import org.springframework.data.jpa.repository.Query; | ||
import org.springframework.data.jpa.repository.QueryRewriter; | ||
import org.springframework.data.repository.query.Param; | ||
import org.springframework.stereotype.Repository; | ||
|
||
import java.util.List; | ||
|
||
@Repository | ||
public interface TicketRepository extends JpaRepository<Ticket, Integer> { | ||
List<Ticket> findByTenant(Tenant tenant); | ||
public interface TicketRepository | ||
extends JpaRepository<Ticket, Integer>, QueryRewriter { | ||
@Query( | ||
value = "SELECT t.id, t.customer, t.description, t.last_updated, t.resolved, t.tenant FROM \"Tickets\" t LEFT JOIN \"Tenants\" t1 ON t1.id=t.tenant WHERE t1.name=:#{#tenant.name}", | ||
nativeQuery = true, | ||
queryRewriter = TicketRepository.class | ||
) | ||
List<Ticket> findByTenant(@Param("tenant") Tenant tenant); | ||
|
||
List<Ticket> findByTenantAndId(Tenant tenant, Integer id); | ||
|
||
@Override | ||
default String rewrite(String query, Sort sort) { | ||
// Omitted: | ||
// 1. get conditions from OPA, after feeding it query and user information | ||
// 2. convert conditions to SQL WHERE clause | ||
// | ||
// SQL logging uncovered **a lot** of queries happening for "list tickets". | ||
// I'd assume that they're done automatically by Spring Data JPA, to ensure | ||
// relationships etc; but it also means they are under the radar of this rewriter. | ||
// However, I'd envision that there's one rewriter that would be used with all | ||
// the repositories, so maybe we would end up covering call queries after all. | ||
String rewritten = query + " AND t.resolved = false"; // leading space is crucial | ||
Logger logger = LoggerFactory.getLogger(App.class); | ||
logger.info("rewritten: " + rewritten); | ||
return rewritten; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ Before, we've let JPA figure out what SQL should be used just from the method signature.
👇 Now, we'll have to spell out the query ourselves.