Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors/warnings #2167

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

dartasen
Copy link
Member

@dartasen dartasen commented Aug 21, 2024

Those are the remaining warnings, but I guess it needs extra work since technically the analyzer is right, but in the whole context it makes absolutely no sense, or add too much complexity for a simple call that will happen 0.0000001% of the time
image

@dartasen dartasen added the Area: dev Related to development environment or dev QoL label Aug 21, 2024
Copy link
Collaborator

@Coding-Hen Coding-Hen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad that the strings are being replaced I noticed that the other day with a rebase I did and spent ages wondering if it was me that broke it

@Measurity
Copy link
Collaborator

Measurity commented Aug 22, 2024

Those are the remaining warnings, but I guess it needs extra work since technically the analyzer is right, but in the whole context it makes absolutely no sense, or add too much complexity for a simple call that will happen 0.0000001% of the time

The problem isn't the performance but that the DI container crashes when there's a cyclical dependency, that's even in 0.0000001% cases since those calls happen from a type that itself also does DI.

We would be better of not using DI on the client if we don't plan on fixing these DI issues.

@dartasen dartasen merged commit 7bbe296 into SubnauticaNitrox:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: dev Related to development environment or dev QoL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants