Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try add es6-promise #93

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

try add es6-promise #93

wants to merge 4 commits into from

Conversation

asukaminato0721
Copy link
Contributor

continue #91

SukkaW
SukkaW requested changes Aug 19, 2024
View reviewed changes
Copy link
Owner

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es6-promise doesn't follow ES Shim. It uses es6-promise/auto, require('es6-promsie'). polyfill() and require('es6-promsie'). Promise。

@jdalton
Copy link

jdalton commented Aug 20, 2024

es6-promise doesn't follow ES Shim. It uses es6-promise/auto, require('es6-promsie'). polyfill() and require('es6-promsie'). Promise。

Different dev 😸 . Certainly helps to have a standard way to interface with shims.

@asukaminato0721 asukaminato0721 marked this pull request as draft August 21, 2024 09:38
@asukaminato0721
Copy link
Contributor Author

I guess besides single file / ES Shim , we need another format.

@SukkaW
Copy link
Owner

SukkaW commented Oct 20, 2024

I guess besides single file / ES Shim , we need another format.

We have manual format.

@asukaminato0721 asukaminato0721 marked this pull request as ready for review October 20, 2024 18:31
@asukaminato0721
Copy link
Contributor Author

not sure whether this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW Awaiting requested review from SukkaW

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asukaminato0721 @jdalton @SukkaW