Skip to content

Commit

Permalink
Disable climate temperature validation when turning off (#1789)
Browse files Browse the repository at this point in the history
* Disable climate temperature validation when turning off

* Update mypy.ini
  • Loading branch information
SukramJ authored Oct 24, 2024
1 parent a0c6090 commit 7f95515
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 4 deletions.
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Version 2024.10.13 (2024-10-24)

- Disable climate temperature validation when turning off

# Version 2024.10.12 (2024-10-19)

- Small tweaks to improve central link management
Expand Down
4 changes: 3 additions & 1 deletion hahomematic/platforms/custom/climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,9 @@ async def set_temperature(
f"SET_TEMPERATURE failed: Invalid temperature: {temperature} (min: {self.min_temp}, max: {self.max_temp})"
)

await self._e_setpoint.send_value(value=temperature, collector=collector)
await self._e_setpoint.send_value(
value=temperature, collector=collector, do_validate=do_validate
)

@bind_collector()
async def set_hvac_mode(
Expand Down
1 change: 0 additions & 1 deletion mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ platform = linux
plugins = pydantic.mypy
show_error_codes = true
follow_imports = normal
enable_incomplete_feature = NewGenericSyntax
local_partial_types = true
strict_equality = true
no_implicit_optional = true
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "hahomematic"
version = "2024.10.12"
version = "2024.10.13"
license = {text = "MIT License"}
description = "Homematic interface for Home Assistant running on Python 3."
readme = "README.md"
Expand Down
6 changes: 5 additions & 1 deletion tests/test_central_pydevccu.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,13 @@ async def test_central_full(central_unit_full) -> None:
assert info_config_props

custom_entities = []
channel_type_names = set()
for device in central_unit_full.devices:
custom_entities.extend(device.custom_entities)

for channel in device.channels.values():
channel_type_names.add(channel.type_name)
channel_type_names = sorted(channel_type_names)
assert len(channel_type_names) == 538
ce_channels = {}
for custom_entity in custom_entities:
if custom_entity.device.model not in ce_channels:
Expand Down

0 comments on commit 7f95515

Please sign in to comment.