Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): get rid of unsafe regular expression for chart version replacing #3626

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Mar 29, 2024

This reverts changes in template tests from f6e9329

regular expression could replace random characters

Screenshot 2024-03-29 at 13 13 38

what seems to happen in https://github.com/SumoLogic/sumologic-kubernetes-collection/actions/runs/8479476276/job/23233572027

    	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -27,3 +27,3 @@
        	            	      (string) (len=11) "annotations": (map[string]interface {}) (len=2) {
        	            	-      (string) (len=15) "checksum/config": (string) (len=17) "%CONFIG_CHECKSUM%",
        	            	+      (string) (len=15) "checksum/config": (string) (len=82) "cbd6863a1bb9610%CURRENT_CHART_VERSION%0a88dd6a9b21781a5cbbe4c9076848d3d521f672b50a",

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@kasia-kujawa kasia-kujawa marked this pull request as draft March 29, 2024 12:16
@kasia-kujawa kasia-kujawa marked this pull request as ready for review March 29, 2024 12:21
@swiatekm
Copy link

I think we originally did it this way because a naive replace will also affect image versions which accidentally happen to be the same as our chart version. But as a quick fix, this is fine.

@kasia-kujawa
Copy link
Contributor Author

I think we originally did it this way because a naive replace will also affect image versions which accidentally happen to be the same as our chart version. But as a quick fix, this is fine.

I opened #3627, we will have time to fix this in smart and safe way ;)

@kasia-kujawa kasia-kujawa merged commit 323ecd0 into main Mar 29, 2024
52 checks passed
@kasia-kujawa kasia-kujawa deleted the kkujawa-fix-tests branch March 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants