Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: /players is seriously out of date #151

Closed
schneefux opened this issue Apr 16, 2017 · 3 comments
Closed

Bug: /players is seriously out of date #151

schneefux opened this issue Apr 16, 2017 · 3 comments

Comments

@schneefux
Copy link
Contributor

The /players endpoint has not seen an update since about 2017-03-15 on all players.

  • See createdAt dates which report all similar dates from one month ago.
  • stats are out of date. Check shutterfly/eu, I have 560 wins not 544.
  • Players that registered after that date cannot be found. Check shutterflySEA/sg, check jokerq1/eu, …

Compare with any result of /matches and see that the stats are up to date on the most recent match.

This is a critical bug, we are trying to migrate in regard of #145 and this is blocking our production release because we cannot serve new users without ugly workarounds that bust the rate limits.

@kvahuja
Copy link
Contributor

kvahuja commented Apr 16, 2017

More than rate limit, we would need 10 calls to get a user. That's going to be awefully slow.

@schneefux
Copy link
Contributor Author

httpie and jq commands for quick testing:

http 'https://api.dc01.gamelockerapp.com/shards/eu/players' "Accept":"application/json" "X-Title-Id":"semc-vainglory" "Authorization":"" "filter[playerNames]"=="jokerq1"
# error 404
http 'https://api.dc01.gamelockerapp.com/shards/eu/matches' "Accept":"application/json" "X-Title-Id":"semc-vainglory" "Authorization":"" "filter[playerNames]"=="jokerq1" "filter[createdAt-start]"=="2017-04-01T00:00:00Z" | jq ".data|length"
# 15 matches

http 'https://api.dc01.gamelockerapp.com/shards/eu/matches' "Accept":"application/json" "X-Title-Id":"semc-vainglory" "Authorization":"" "filter[playerNames]"=="shutterfly" "filter[createdAt-start]"=="2017-01-01T00:00:00Z" "sort"=="-createdAt" "page[limit]"==1 | jq ".included[] | select(.attributes.name == \"shutterfly\") | .attributes.stats.wins"
# 560 wins
http 'https://api.dc01.gamelockerapp.com/shards/eu/players' "Accept":"application/json" "X-Title-Id":"semc-vainglory" "Authorization":"" "filter[playerNames]"=="shutterfly" | jq ".data[].attributes.stats.wins"
# 544 wins

@bguilder
Copy link
Collaborator

All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants