Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented donate contract (with address registrar) #1

Merged
merged 15 commits into from
Dec 15, 2018
Merged

Implemented donate contract (with address registrar) #1

merged 15 commits into from
Dec 15, 2018

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Aug 15, 2018 •
edited
Loading

  • Add failsafe/escape hatch that can be triggered by verifier that disables all deposits and only allows for refunds
  • Write basic tests
    • Write TODOs for testing different functionality/forbidden behavior, planning for extensive (and hopefully systematic) unit testing have been planned.

@ErikBjare ErikBjare mentioned this pull request Aug 15, 2018
Open
@ErikBjare
Copy link
Member Author

This now has passing tests and works alright as a PoC, so merging it.

@ErikBjare ErikBjare merged commit fd535b5 into master Dec 15, 2018
@ErikBjare ErikBjare deleted the dev/addressregistrar branch December 15, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnlabb ahnlabb Awaiting requested review from ahnlabb

@johan-bjareholt johan-bjareholt Awaiting requested review from johan-bjareholt

@patriklaurell patriklaurell Awaiting requested review from patriklaurell

@Powersource Powersource Awaiting requested review from Powersource

@vlthr vlthr Awaiting requested review from vlthr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ErikBjare