Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spec/package):about model of sutera package using yaml #67

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

slotsu0809
Copy link
Contributor

close #37

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

textlint

package/About_model_of_sutera_package_using_yaml.md|39 col 42| 漢字が7つ以上連続しています: 次元直行座標系 (ja-technical-writing/max-kanji-continuous-len)
package/About_model_of_sutera_package_using_yaml.md|39 col 53| 箇条書き: "である"調 と "ですます"調 が混在
=> "である"調 の文体に、次の "ですます"調 の箇所があります: "ます。"
Total:
である : 0
ですます: 17
(ja-technical-writing/no-mix-dearu-desumasu)
package/About_model_of_sutera_package_using_yaml.md|39 col 55| Should remove period mark("。") at end of list item. (period-in-list-item)
package/About_model_of_sutera_package_using_yaml.md|40 col 34| 箇条書き: "である"調 と "ですます"調 が混在
=> "である"調 の文体に、次の "ですます"調 の箇所があります: "です。"
Total:
である : 0
ですます: 17
(ja-technical-writing/no-mix-dearu-desumasu)
package/About_model_of_sutera_package_using_yaml.md|40 col 81| 箇条書き: "である"調 と "ですます"調 が混在
=> "である"調 の文体に、次の "ですます"調 の箇所があります: "ます"
Total:
である : 0
ですます: 17
(ja-technical-writing/no-mix-dearu-desumasu)
package/About_model_of_sutera_package_using_yaml.md|86 col 1| Line 86 sentence length(107) exceeds the maximum sentence length of 100.
Over 7 characters. (ja-technical-writing/sentence-length)
package/About_model_of_sutera_package_using_yaml.md|87 col 76| 文末が"。"で終わっていません。 (ja-technical-writing/ja-no-mixed-period)

package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
@slotsu0809 slotsu0809 marked this pull request as ready for review August 4, 2024 09:51
@slotsu0809 slotsu0809 requested a review from AsPulse August 4, 2024 09:52
@slotsu0809
Copy link
Contributor Author

@See2et

Copy link
Member

@See2et See2et left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これひとりで書いてくれたんですか!?おつかれさまてんきゅーすぎる!!!

package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
@See2et
Copy link
Member

See2et commented Aug 8, 2024

@AsPulse せかんどれびゅーたのんます!おねがい!なんでもするかも!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

textlint

🚫 [textlint] <eslint.rules.ja-technical-writing/sentence-length> reported by reviewdog 🐶
Line 71 sentence length(107) exceeds the maximum sentence length of 100.
Over 7 characters. (ja-technical-writing/sentence-length)

^[1~] YAML (「YAML Ain't Markup Language」の再帰的頭字語) は、人間に優しく、日常の一般的なタスクで最新のプログラミング言語とうまく連携するように設計されたデータシリアル化言語です。^[2]


🚫 [textlint] <eslint.rules.ja-technical-writing/ja-no-mixed-period> reported by reviewdog 🐶
文末が"。"で終わっていません。 (ja-technical-writing/ja-no-mixed-period)

^[2~] yaml公式サイトspecification v1.2.2 https://yaml.org/spec/1.2.2/ 閲覧2024/7/23

@See2et
Copy link
Member

See2et commented Aug 12, 2024

textlintくんうるさすぎるので一旦これで黙らせてもいいかも

<!-- textlint-disable -->
ここに偽陽性が出る文章
<!-- textlint-enable -->

@slotsu0809
Copy link
Contributor Author

@AsPulse れびゅーおねがいします!落ち着いたときで大丈夫です!

Copy link
Contributor

@AsPulse AsPulse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずPRのタイトルをConventional COmmitに沿った形式にしてください!

あとこれ、prh案件が多いね……
基本的に文章中に登場する「仕様として正式な文字列を表す」部分は、backquoteでかこってください。 (正式な文字列であることを明示する目的や、翻訳の際に誤って訳されるのを防ぐ目的などがあります。)
たとえば

  • 設定しない場合は空配列[]を設定してください。 (29行目)
  • 球の半径rを設定してください。 (39行目)

また、命名規則はsnake_caseでお願いします

体裁のレビューの他に中身のレビューもしないといけないので、一旦中身のレビューはできていないのですが送っちゃいますね!

package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
Comment on lines 45 to 46
#### cupsule
カプセル方のコライダーです。球の半径rと高さhを指定してください
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### cupsule
カプセル方のコライダーです。球の半径rと高さhを指定してください
#### capsule
カプセル形のコライダーです。球の半径rと高さhを指定してください

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slotsu0809 ここだけまだ未修正かも!

package/About_model_of_sutera_package_using_yaml.md Outdated Show resolved Hide resolved
[model.yaml](./model.yaml)に本項目で説明したワールドに設置する3Dモデルに関するyamlファイルの例が記載されています。

## 参考文献,脚注
^[1~] YAML (「YAML Ain't Markup Language」の再帰的頭字語) は、人間に優しく、日常の一般的なタスクで最新のプログラミング言語とうまく連携するように設計されたデータシリアル化言語です。^[2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [textlint] <eslint.rules.ja-technical-writing/sentence-length> reported by reviewdog 🐶
Line 71 sentence length(107) exceeds the maximum sentence length of 100.
Over 7 characters. (ja-technical-writing/sentence-length)


## 参考文献,脚注
^[1~] YAML (「YAML Ain't Markup Language」の再帰的頭字語) は、人間に優しく、日常の一般的なタスクで最新のプログラミング言語とうまく連携するように設計されたデータシリアル化言語です。^[2]
^[2~] yaml公式サイトspecification v1.2.2 https://yaml.org/spec/1.2.2/ 閲覧2024/7/23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [textlint] <eslint.rules.ja-technical-writing/ja-no-mixed-period> reported by reviewdog 🐶
文末が"。"で終わっていません。 (ja-technical-writing/ja-no-mixed-period)

@slotsu0809 slotsu0809 changed the title Docs/about model of sutera package using yaml docs(spec/package)about model of sutera package using yaml Aug 18, 2024
@slotsu0809 slotsu0809 changed the title docs(spec/package)about model of sutera package using yaml docs(spec/package):about model of sutera package using yaml Aug 18, 2024
z: 1
```
#### `sphere`
球形のコライダーです。球の半径`r`を指定してください
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
球形のコライダーです。球の半径`r`を指定してください
球形のコライダーです。球の半径`r`を指定してください

```

#### `cupsule`
カプセル方のコライダーです。球の半径`r`と高さ`h`を指定してください
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
カプセル方のコライダーです。球の半径`r`と高さ`h`を指定してください
カプセル方のコライダーです。球の半径`r`と高さ`h`を指定してください

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(spec/package): Suteraパッケージのモデルについて (yamlフォーマット)
3 participants