Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup ci #7

Merged
merged 8 commits into from
Sep 16, 2024
Merged

feat: setup ci #7

merged 8 commits into from
Sep 16, 2024

Conversation

HMasataka
Copy link
Contributor

@HMasataka HMasataka commented Sep 1, 2024 •
edited
Loading

  • github action でtest, clippy, rustfmtを実行

close: #3

@HMasataka HMasataka marked this pull request as ready for review September 13, 2024 06:53
AsPulse
AsPulse requested changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@AsPulse AsPulse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • どれでチェックが落ちたのか分かりづらいのでワークフロー分けてほしいです！
  • shell: bash不要ですが一応付けてる感じですか……？
  • toolchainなんですけど、rust-toolchain.tomlを見るはずなので不要です

@HMasataka
Copy link
Contributor Author

HMasataka commented Sep 14, 2024 •
edited
Loading

直します！

shell: bash不要ですが一応付けてる感じですか……？

GitHub Actionsだとshell指定しないかbash指定するかで内部で実行されるコマンドが違ってて指定した方が良いケース多いみたいだから一応付けてましたー
今回はそれほど重要でもないので消しても良いかも
https://docs.github.com/ja/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell)

@HMasataka HMasataka requested a review from AsPulse September 15, 2024 00:48
@HMasataka
Copy link
Contributor Author

ひとまず指摘部分消してワークフロー組み直しました

AsPulse
AsPulse approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@AsPulse AsPulse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@HMasataka HMasataka merged commit 8f9d6bf into main Sep 16, 2024
4 checks passed
@HMasataka HMasataka deleted the feature/setup_ci branch September 16, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsPulse AsPulse AsPulse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: build, rustfmt, clippy, test
2 participants
@HMasataka @AsPulse