Tests for haven package #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghaynes
reviewed
Jul 18, 2024
|
|
||
| l_labels <- lapply(data_sas, attr, "label") | ||
|
|
||
| test_that("Column 1 label is correct", expect_equal(l_labels$ProductKey, "Product Key")) |
There was a problem hiding this comment.
I'm not sure how haven labels variables, but would it not be easier to do
expect_equal(label(data_sas$SupplierName), "Supplier Name") (or var_label(...) if it uses the labelled package)
I would imagine that this more closely matches how it would be used in practice...
aghaynes
reviewed
Jul 18, 2024
|
|
||
| #compare column 1 | ||
| test_that("Column 1 matches" | ||
| , expect_equal( |
There was a problem hiding this comment.
i think i would be inclined to do something like
expect_true(all(data_csv$ProductKey == data_sas$ProductKey))
|
Great that it worked! Do the tests also work via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The folder "haven" contains the necessary files for testing the function read_sas from the haven package.