-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: single sidecars exe and versioned templates #745
Conversation
The previous commit left out the statefulset volumes and volume mounts
This adds an option for the sidecars that are templated by Amalthea to be versioned. Also it combines all the executables that run in the sidecars that Amalthea adds to live in a single executable.
778f090
to
0326146
Compare
0326146
to
053b757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good however I am just not sure about what "template" refers to in this context.
There's the fact that these are template functions but in the k8s context, some resources such as deployment uses template in the sense of "reference pod declaration to be used when creating pods".
In this case "template" means the real k8s children resources I generate from the CR specification. I.e. the PVC, Ingress, Service, Statefulset, etc. |
This change is part of the following stack: Change managed by git-spice. |
There are a few things that happen here:
This later part about "versioned templating" is required to prevent the following scenario:
There are other reasons too. For example we upgrade the version of the sidecar image but its api has changed. Then either new sessions with the new sidecar work or the old ones are patched restarted but now when they start back up they keep crashing because the sidecars image API has changed.