feat: get secret from pvc annotation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it os that the secret that contains the configuration for rclone which is needed to mount this does not have to be named the same as the PVC. But an annotation for the PVC makes the csi driver load the secret automatically - this is common for csi drivers and it is functionality you get for free. If no annotation is provided then the driver uses the old method of loading a secret named the same as teh PVC.
olevski
force-pushed
the
feat-get-secret-from-pvc-annotation
branch
3 times, most recently
from
fd8bdd1 to
3aa87d6
Compare
olevski
force-pushed
the
feat-get-secret-from-pvc-annotation
branch
from
886b77e to
9538027
Compare
Panaetius
requested changes
Sep 2, 2024
Closed
|
This change is part of the following stack: Change managed by git-spice. |
Panaetius
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the driver.
Most notable is the change to the storage class which required the sidecar versions to be updated. Also because I could not get nix to work - I even undid go package updates because nix needed some manual step to update a single sha for handling the go packages. So because of this I added a dockerfile and made chartpress build and push the image rather than nix.