Publish an example #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Made $this->version a define (VERSION). + Made $this->errors really static (self::$errors). + Moved encodeAsciiToChar() out from the class to the namespace root as a general utility fn. + Moved getGif to the "public" section (and removed the Getter/Setter section). + Moved reset() closer up to the ctor. + Changed comments here & there. + Changed the error messages slightly (those might get removed anyway, though). + Whitespaces: fixed some tab/space mismatch etc.
+ Left the namespace as "GifCreator" (intentionally).
+ Renamed method getGif() to get().
+ Changed {$i} indexes to [$i] in gifBlockCompare().
(Ehh... How can I do commit --amend here?)
+ small formatting craps
! Haven't (and probably won't ever!) test the current version at all! ? Move to PSR-4 anyway? (We depend on PHP 5.3+ already.)
"Fatal error: Namespace declaration statement has to be the very first statement in the script"
Parse error: syntax error, unexpected T_PUBLIC in P:\JOB+CONTRACT_\Bulesz\WeatherCert\sys\common\animgif.php on line 352
+ Separate ERR00 from $durations not being an array. + Support uniform timing without an array.
+ $duration now has a meaningful default in create(). + $frames was incorrectly made an optional arg. of create().
+ create() should iterate $frames with foreach() not for assuming direct indexes from 0 to < count. (The array keys can be anything, and should not affect the results.) + Removed unused $mode from reporting ERR02.
(Actually, reset() was public already; made the internals protected, in fact.)
Also: improved comments and error messages.
(I didn't want to force this, but to keep GIT shut up over the empty test dir, I have a .KEEP file there, so...)
Now allows for a GIF which does not loop to be created.
Fixes Non-Looped GIFs
...with Peter Sellers, Ringo Star, John Cleese, Graham Chapman and others (like Richard Attenborough and Roman polanski): The Magic Christian. Do check it out, it's amazingly embarrassing and delightful ad the same time! :)
Also corrected is the loop value which should be zero based.
Corrected typo in GIF header generation, fixes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you guys publish an example. I cannot make it work . I get stuck at ..and "send it directly to the browser:" and only get strange code (I guess it is the binary)