WIP: add methods for automatic unit conversion for SymbolicDimensions #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @gaurav-arya
This makes it so that you can add
1.5us"km"
with1500us"m"
and there won't be a dimension error. It will choose to convert to the leftmost dimension.I'm not sure if that's the best thing to do though (maybe we should force users to stay in the same dimensions), so any thoughts appreciated!
e.g., this would make your chemistry example possible with symbolic dimensions throughout. You could add
J
andeV
and not have it be converted to SI units.