Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: folder restructure CF-552 #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sheilf-synapse
Copy link
Contributor

@sheilf-synapse sheilf-synapse commented Nov 9, 2022

Description:

Updates folder structure to get SDK repositories revived and aligned across SDKs

Concern:

What is our approach to changes like these? How do we confirm safety, stability and validity of changes?

Pending updates:

  • variable name change + function name ordering to make SDKs more predictable
  • requests 2.20.1 -> 2.28.1
  • improved type annotations

Visuals:
Running unittests to confirm that folder changes may be non-breaking when the code communicates messages across files.

image

@sheilf-synapse sheilf-synapse marked this pull request as ready for review November 10, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant