-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ansi escape and readline so output doesnt mix with input in cli #638
base: master
Are you sure you want to change the base?
Conversation
In Windows I get the following error: I assume that this is because readline has not been added to the buildPy2exe include list, i.e.: Line 682 in 20846ca
|
This reverts commit fd21422.
I could be wrong, but I think the reason it errors on your reverted Windows tweak is because readline needs to be added to requirements.txt. |
It seems there's no native readline implementation for windows, I think it's too much to handle, I will just check for the current system and disable this feature if readline is unavailable |
Ah, okay. |
Just checked, and it looks like if there was demand for that functionality in the future it might be possible to do so with pyreadline3, but nobody has raised any concerns about the current behaviour of SynplayConsole.exe so for now it doesn't seem worth the complexity. |
I've tried to test this on Debian 13 - with this change closing the application (either by ctrl+c or by closing the media player) results in basically non-functional prompt. As in typing commands further doesn't cause them to show up for example, ctrl+c adds two new lines etc. EDIT: just to specify - I have tested this with the CLI mode (--no-gui). Which is actually used by at least several people who made comments in various issues over the yers. Since I'm not quite sure what exactly in detail is wrong with current behavior of Syncplay and what's the expected result of this pull request would actually do - only feedback I can currently provide is that this doesn't seem good. Could you explain what the "output doesnt mix with input in cli" means in an example? |
I'm using largely standard Debian, so this is just bash. What distro/terminal did you use? |
It works on linux, tell me if I should handle Windows console differently