Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes + DSM6 support #8

Closed
wants to merge 7 commits into from
Closed

Conversation

Dr-Bean
Copy link
Contributor

@Dr-Bean Dr-Bean commented Dec 20, 2016

Various fixes to get the tests to run succesfully, and add support for DSM6-related changes to package management.

@Dr-Bean
Copy link
Contributor Author

Dr-Bean commented Dec 20, 2016

I assumed that the formatting of privilege and resource was the same as for PKG_DEPS...it's not.
Besides, I left one line in utils.py which shouldn't be there, causing an upload to fail. I'll come back to this once again...

- Remove duplicate line
- Just make sure we can read privilege and resource files in UTF-8, no
further processing needed.
@Dr-Bean
Copy link
Contributor Author

Dr-Bean commented Dec 21, 2016

Upload works (locally anyway). The one failing test (test_anonymous) on Travis occurs locally too, not sure what the reason is to get a 302 instead of a 403.

@Diaoul, your flask-login fork is no longer available, hence the change in requirements.txt with 2ffe838. Travis wouldn't run otherwise. Was the issue fixed upstream, or did you set the fork to private or something?

@Dr-Bean
Copy link
Contributor Author

Dr-Bean commented Jan 11, 2017

ping @Diaoul. I realize you're probably busy with other things, but merging and publishing this allows us to move forward with DSM6 stuff. Thanks :)

@Diaoul
Copy link
Member

Diaoul commented Jan 11, 2017

Yes I just moved so quite busy indeed. Publishing this will probably break the server and I need to be available to make appropriate fixes this is why I didn't publish it yet. I'll let you know when I can do that, probably in a week or so.

@Dr-Bean
Copy link
Contributor Author

Dr-Bean commented Jan 11, 2017

Hope the new place is nice :) Take your time...that's coming from someone who's still surrounded by unemptied moving boxes :/

@m4tt075
Copy link

m4tt075 commented Aug 17, 2017

@Diaoul Is this still being worked on or abandonded for good? Both is perfectly fine of course, but I'm asking to understand whether we can continue using Synocommunity as publication platform or whether we should better be looking for alternatives moving forward. Any insights appreciated.

@Safihre
Copy link

Safihre commented Sep 26, 2017

Ping @Diaoul I also wonder if this is ever going to be finished and merged?
Thanks! 👍

@hgy59 hgy59 mentioned this pull request Apr 1, 2018
@MatthiasLohr
Copy link

Any update here?

@m4tt075
Copy link

m4tt075 commented Jan 11, 2019

This is obsolete. @ymartin59 fixed it. We have been publishing 6.1 packages for many months already. The repo is perfectly fine. The problem was that certain packages needed to be updated to support 6.1 and beyond too. If you are interested in details and the list of packages that still need to be tackled, please take a look here: SynoCommunity/spksrc#2904.

@ymartin59
Copy link
Collaborator

In fact changes here are interesting even if not mandatory for DSM 6 package to be published. And have been merged into master - this PR is left opened as a reminder that it has not been published yet in production - refactoring to Docker container is expected...

@Diaoul Diaoul closed this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants