use resource linker for DSM6 #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SPK_LINKS is not supported anymore, use SPK_USR_LOCAL_LINKS and/or SPK_COMMANDS - adjust all packages with former SPK_LINKS (beets, borgbackup, rdiff-backup)
- resource workers for ports/links/shares are supported from DSM>=6.0
- keep the /usr/local/{package} link in DSM 6 for now, as not all dependent packages are redesigned
yes, here we can Co-authored-by: Sebastian Schmidt <[email protected]>
- rename and remove obsolete DSM 5 code
ymartin59
approved these changes
Apr 28, 2021
hgy59
added a commit
to hgy59/spksrc
that referenced
this pull request
Apr 30, 2021
- fixes SynoCommunity#4578 for packages without specific conf files
hgy59
added a commit
that referenced
this pull request
Apr 30, 2021
- fixes #4578 for packages without specific conf files
3 tasks
3 tasks
|
Sorry to bump this old PR @hgy59. But I think this one introduced an error in the In current master, some commands are included for the case of DSM < 6.0. But the line defining the target is within the DSM >= 6.0 conditional part only. So the commands belong to nowhere when on older DSM versions and the Line 206 in a91c960 What file is this output supposed to go to then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: This is the resource linker part of #4562
Linked issues: #4524, #4539
Checklist
all-supportedcompleted successfullyRemarks
SPK_LINKSMakefile variable and useSPK_USR_LOCAL_LINKSfor DSM6 and DSM5.SPK_USR_LOCAL_LINKSinstead ofSPK_LINKSWIP:
Redesign DSM6 installer to use resource definitions for Links, FwPorts, SHARES similar to DSM7
Only keep creation of
/usr/local/{package}link to avoid breaking already installed packages that lean on thisReferences