Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtommath and libtomcrypt #5816

Closed
wants to merge 2 commits into from

Conversation

vitkabele
Copy link
Contributor

Description

During my attempts to port the Firebird SQL database (related to #5795), I came across the need of also porting the dependent libtommath and libtomcrypt libraries.
Not knowing how my attempts with Firebird will end, I'd like to share the intermediate results with the community. My changes do not create new package, just provides libraries that can be used during the build of dependent software.

Both libraries compile with make all-supported and place the library objects in the destination directory.

I will be glad for any feedback.

Thank you.

Checklist

  • Build rule all-supported completed successfully (yes for both)
  • New installation of package completed successfully (no package, just library in cross/)
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@vitkabele
Copy link
Contributor Author

I found out that these won't be needed for the Firebird package in the end. I would need them in native/ instead of cross. I did not fully understand the Firebird compilation process initially.
They can however still be merged if you think someone would benefit from them.

@vitkabele
Copy link
Contributor Author

So, the libtom* libraries are not needed for cross/, but in native/. I have both versions and I can push all of them. The native/libtom* are however part of my Firebird branch and I can merge them eventually all together with the Firebird

@vitkabele
Copy link
Contributor Author

After further investigation, these won't be needed at all for FirebirdSQL spk. Closing this pull request as it is no longer relevant.

@vitkabele vitkabele closed this Aug 7, 2023
@vitkabele vitkabele deleted the libtom branch August 29, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant