Added new package gpac v2.2.1

[wmanth]

Description

This PR brings MP4Box to Synology NAS.

Checklist

• Build rule all-supported completed successfully
• New installation of package completed successfully
• Package upgrade completed successfully (Manually install the package again)
• Package functionality was tested
• Any needed documentation is updated/created

Type of change

• Bug fix
• New Package
• Package update
• Includes small framework changes
• This change requires a documentation update (e.g. Wiki)

[mreid-tt]

@wmanth, it's advisable to avoid doing a force push for each change you make. This practice can obscure smaller alterations within a large commit, making it challenging for others to review. Moreover, if someone has cloned your branch for testing purposes, a force push will disrupt their instance, necessitating manual resynchronisation and complicating peer reviews.

EDIT: The quantity of commits in your pull request holds no significance, as our standard practice involves squashing and merging to incorporate your code into the main repository.

[wmanth]

Basically, my PR is done. No changes pending after incorporating the previous review comment. I did just rebase my commit to latest master as no checks have been triggered before.

[mreid-tt]

@hgy59, whenever you're ready, please do let me know if you've completed your review and approval. I am ready to assist with the merge and publishing process.

[hgy59]

@mreid-tt Since it's a CLI tool, not much can go wrong.
I'll be offline for a few days, so your review is probably enough...

[mreid-tt]

@wmanth, apologies for my earlier comment about not being able to launch gpac. I realise you do have a SPK_COMMANDS defined for MP4Box. I assume this is the only binary to be defined? I ask because in your description you have "It features the MP4 reference muxer MP4Box, and many other tools", so I was wondering where the other tools were.

Otherwise the package looks good to go.

[wmanth]

@mreid-tt I copied the description from their website a while ago before they restructured their tools in the latest version. Just updated the PR and removed the many other tools part from the description. Also added the gpac tool to the list of binaries.

[mreid-tt]

@wmanth, your package has beeb published. It may take 24-48 hours to propagate through to the global cache before it shows up in the Package Center on your NAS. You can see it listed at https://synocommunity.com/package/gpac.

One thing I missed was a change-log but we can make sure to include that in a future update.

[wmanth]

@mreid-tt Thanks for your support and merging the PR! I saw the change-log setting, but due to the fact this being a new package added to the SynoCommunity repo I didn't see any reason to add a change log.

[mreid-tt]

@mreid-tt Thanks for your support and merging the PR! I saw the change-log setting, but due to the fact this being a new package added to the SynoCommunity repo I didn't see any reason to add a change log.

You're welcome. Usually for a new package we like to put "Initial release".

[wmanth]

Usually for a new package we like to put "Initial release".

I assume a force-push to fix this is not a preferred solution 😏. I'd also like to get the Co-authored-by: Wolfram Manthey <[email protected]> removed from the squashed commit message, which happed due to a local git configuration issue. But probably no one cares.

[mreid-tt]

Sorry, I should have removed that but I clicked one too many times on the merge. Won't be changeable at this point unfortunately.