Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazarr: update 1.4.0 => 1.4.2 #6024

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Bazarr: update 1.4.0 => 1.4.2 #6024

merged 4 commits into from
Mar 31, 2024

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Mar 2, 2024 •
edited
Loading

Description

Update bazarr 1.4.0 => 1.42.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested

Type of change

  • Package update

@hgy59
Copy link
Contributor

hgy59 commented Mar 10, 2024

@smaarn while analyzing the Makefiles of all packages I found that spk/bazarr/Makefile has duplicate definition of HOMEPAGE and LICENCE.

Can you please fix this with this PR?.
please keep the short form of LICENSE = GPLv3 and remove LICENSE = GPL-3.0 license

@smaarn smaarn marked this pull request as ready for review March 10, 2024 20:13
@smaarn smaarn changed the title [WIP] Bazarr: update 1.4.0 => 1.4.2 Bazarr: update 1.4.0 => 1.4.2 Mar 10, 2024
@smaarn smaarn requested a review from hgy59 March 10, 2024 20:14
hgy59
hgy59 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hgy59 hgy59 merged commit e5f1ac5 into SynoCommunity:master Mar 31, 2024
17 checks passed
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Apr 2, 2024
@smaarn smaarn deleted the feat/bazarr/update-1.4.2 branch June 2, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 hgy59 approved these changes

Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaarn @hgy59