-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SRM 1.3 toolchains #6318
add SRM 1.3 toolchains #6318
Conversation
@mreid-tt I get an error, when adding the srm 1.3 input fileds to the workflow file how can we solve this? |
@hgy59, this is an interesting constraint since it would mean that we need to reconsider the matrix generation in the future given we are limited to 10 input fields. For now, I would recommend the following:
|
- add toolchains extracted from toolkit from Synology downloads - hawkeye is an early release and seems incorrect (router model WRX560 not yet released)
@hgy59 I'll have a look at it tomorrow but at first glance shouldn't lua update be in a separate pr? |
I had to change a package to trigger the build workflow, and lua was the package wanted for SRM 1.3 (#6191 (comment)), but of course it should be separated. |
This reverts commit aff39e3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Also I believe this is using your "own-made" toolchain based on the toolkit that you published on our github? If that is the case well 1) well done really and 2) would you have a HOWTO somewhere we could rely on for other similar archs in the future?
TC_NAME = syno-armv7 | ||
|
||
# generic toolchain for arm7hf SRM | ||
TC_ARCH = ipq806x dakota |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it also contain all archs such as: northstarplus ipq806x dakota hawkeye
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
northstarplus is not supported (limited to SRM 1.2)
and hawkeye is a mess: the cpu is aarch64 but the toolchain is binary the same as dakota, therefor I didn't add it to a generic arch yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a comment? at least for hawkeye to avoid confusion later-on?
The how to is provided in the description of the release:
|
I had not noticed, thnx and again, well done! |
Description
Fixes #5402
Update lua package to trigger a build workflow...
Remarks
hawkey (router model WRX560) is suggested not to work
some kernel- and glibc-versions have to be veryfied - those are not documented in the toolkit (content/name) like all DSM toolkits.
the toolchains are availabel under https://github.com/SynoCommunity/spksrc/releases/tag/toolchains/srm1.3
it is documented there how the toolchains were extracted from the toolkit files
Checklist
all-supported
completed successfullyType of change