Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Fix to handle empty matrix #6369

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Jan 2, 2025

Description

This PR introduces a conditional check to skip the build action when no dependent packages are identified, optimizing workflow efficiency and avoiding unnecessary builds.

Relates to #6366

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@mreid-tt mreid-tt self-assigned this Jan 2, 2025
@mreid-tt mreid-tt requested a review from hgy59 January 2, 2025 21:40
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreid-tt mreid-tt merged commit 5fe5ba6 into SynoCommunity:master Jan 2, 2025
1 check passed
@mreid-tt mreid-tt deleted the fix-build-matrix branch January 2, 2025 23:14
@hgy59
Copy link
Contributor

hgy59 commented Jan 2, 2025

@mreid-tt as you can see in https://github.com/SynoCommunity/spksrc/actions/runs/12590111009 it works.

The real reason is that no packages are to build, but I can accept this solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants