-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synocli-file: update tools and remove fd-find for hi3535 #6372
Conversation
- allow current rust version for ARMv7L archs (avoid limit to 1.77.2) - Remove fd (fd-find) for VS and NVR models (ARMv7L archs) - Update eza to v0.20.15 - Update file to v5.46 - Update fzf to v0.57.0 - Update nano to v8.3 - Update nnn to v5.0 (DSM 7 only) - Update tree to v2.2.1
- not supported for ARMv5 anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -47,7 +47,6 @@ ifeq ($(findstring $(RUST_ARCH), $(ARMv7_ARCHS)),$(RUST_ARCH)) | |||
RUST_TARGET = armv7-unknown-linux-gnueabihf | |||
endif | |||
ifeq ($(findstring $(RUST_ARCH), $(ARMv7L_ARCHS)),$(RUST_ARCH)) | |||
RUSTUP_DEFAULT_TOOLCHAIN = 1.77.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remind me, removing this constraint works for armv7l ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it works.
With the constraint, bat
(synocli-file) and dua
(synocli-disk) fail for ARMv7L.
package home v0.5.11
cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.77.2
TODO: synocli-disk has to drop support for dua
for ARMv5 (does not support rust > 1.77.2, as you mentioned)
Description
Fixes #
Checklist
all-supported
completed successfully (only mkvtoolnix as dependency of cross/file fails to download boost libraries)Type of change