rutorrent: upgrade 4.3.7 => 5.1.5 #6404
Conversation
* Bump PHP requirement to 8.2
smaarn
changed the title
spk/rutorrent/Makefile
Outdated
|
|
||
| # newer libtorrent-rakshasa requires C++14 support | ||
| REQUIRED_MIN_DSM = 7.0 | ||
| UNSUPPORTED_ARCHS = comcerto2k | ||
|
|
||
| SPK_DEPENDS = "WebStation:python311:PHP7.4:Apache2.4" | ||
| SPK_DEPENDS = "WebStation:python311:PHP8.2:Apache2.4" |
There was a problem hiding this comment.
with PHP 8.2 the package must define REQUIRED_MIN_DSM = 7.2
DSM 7.1 is limitted to PHP 8.0
We can either use PHP8.0 or create two different profiles for DSM 7.1 and DSM 7.2.
@mreid-tt has limitted spk/cops to DSM 7.2
There was a problem hiding this comment.
Rollbacked the PHP upgrade to 7.4 (since it's still supported by DSM 7.2).
We could enforce the upgrade of PHP but then I would recommend solely to upgrade to 8.0 (since it's the only one supported starting from DSM 7), WDYT ?
There was a problem hiding this comment.
I recommend first examining why you want to upgrade. If it's to maintain a supported PHP version, note that PHP 8.0 is already beyond its active and security support period.
According to Synology’s own release notes for PHP 8.0, version 8.0.28-0120 requires DSM 7.2 or higher, and PHP 7.4’s release notes show that version 7.4.33-0130 also requires DSM 7.2 or above. Both changes took effect on 2023-05-22, meaning any current Synology-provided PHP version now needs DSM 7.2.
Given that Synology hasn’t released PHP 8.3 or 8.4—both still in active support—sticking with PHP 7.4 may be less disruptive, especially for users on older DSM 7 versions who don’t want to install an additional PHP package. The security implications are similar to those on PHP 8.0, since neither can be updated to newer releases (post-2023-05-22) under older DSM versions.
|
@smaarn I already have a local update to rutorrent 4.3.9 including updates for
and work on spk/rutorrent in progress to:
If you don't mind I could add the updated dependencies soon and help with the spk definitions later... |
@hgy59 by all means, do ! This PR was just to kick off the upgrade work in a "minimal" effort mode (e.g. have the build passing, play with things to see if there needs to be more advanced config changes...). |
- update cross/libtorrent-rakshasa from v0.13.8 to v0.14.0 (drop specific commit by hash) - update cross/rtorrent from v0.9.8 to v0.10.0 (drop specific commit by hash) - update cross/xmlrpc-c from v1.51.06 to v1.59.03 - spk/rutorrent: - drop rutorrent.sc (same as default, generated by spksrc.spk.mk) - adjust changelog
- add cross/screen5 (requires DSM 7, i.e. std c17)
… rutorrent/upgrade-5.1
|
@smaarn dependencies updated (and master merged into this) Thanks to #6255 the github prepare action takes now less than one minute including the source download. For spk/rutorrent files, further investigation is required. @mreid-tt shall we try to update this package for DSM 7.1 with PHP 8.0 and DSM 7.2 with PHP 8.2? |
@hgy59, we can try both yes. I am a bit unsure why we are bumping the PHP version however since the release notes for ruTorrent don't seem to make any special mention of a minimum PHP 8 requirement. If this is in fact needed then a build for different versions of PHP will show errors when run with incompatible versions (similar to #6229). |
@mreid-tt actually I was under the impression that I couldn't install PHP 7.4 on my DSM (7.2). Turns out I was wrong. We can definitely avoid upgrading then. I'm not sure, though, about a "build" for different versions of PHP causing incompatibilities (it's only runtime dependencies from what I recall), right ? I will revert the PHP upgrade anyway since it would minimize the "risk" of this upgrade. |
Description
Checklist
all-supportedcompleted successfullyType of change