Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publish #6418

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix publish #6418

merged 1 commit into from
Jan 25, 2025

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 25, 2025

Description

related to #6406 (comment)

This is a hotfix since publish python311 and related packages is broken

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Includes small framework changes

- avoid PYTHONPATH definition for http tool
- PYTHONPATH is defined spksrc.crossenv.mk and was introduced with SynoCommunity#6282
@hgy59 hgy59 requested a review from th0ma7 January 25, 2025 08:18
@hgy59
Copy link
Contributor Author

hgy59 commented Jan 25, 2025

@th0ma7 I guess we can't omit the defintion of PYTHONPATH in spksrc.crossenv.mk

since the publish target depends on the build targets, IMHO the overwrite of the variable when using http command is a reasonable solution.

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 25, 2025

@th0ma7 the http python script is part of httpie that is installed in the development environment.

We might use an alternate tool like curl.

We use the following python based apps in the environment.
can you please veryfy whether none of the others is affected by the PYTHONPATH variable?

RUN apt install --no-install-recommends -y \
	httpie \
	mercurial \
	meson \
	ninja-build \
	python3 \
	python3-distutils \
	python3-mako \
	python3-pip \
	python3-virtualenv \
	python3-yaml

candidates are mercurial, meson and ninja-build when used for non python dependencies but run in a python dependent package.

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 25, 2025

We might use an alternate tool like curl.

more than 10 years ago the download tool was changed from curl to http/httpie in abcf153

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Lgtm

@hgy59 hgy59 merged commit 48b603e into SynoCommunity:master Jan 25, 2025
1 check passed
@hgy59 hgy59 deleted the fix_publish branch January 25, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants