Merge branch 'designer-ui-bugfixes' into 'main'

Designer UI bugfixes See merge request reportcreator/reportcreator!356
Syslifters · Nov 30, 2023 · 38fd8f1 · 38fd8f1
2 parents fc4cb29 + 673ab36
commit 38fd8f1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/frontend/src/components/Design/LayoutComponentForm.vue b/frontend/src/components/Design/LayoutComponentForm.vue
@@ -5,6 +5,7 @@
         v-model="form.headline.text"
         label="Headline"
         :disabled="props.disabled"
+        spellcheck="false"
         class="mb-4"
       />
       <s-select
@@ -49,6 +50,7 @@
         label="Markdown Variable"
         hint="Variable name of report or finding field (e.g. report.executive_summary, finding.description)"
         :disabled="props.disabled"
+        spellcheck="false"
         class="mb-4"
       />
     </div>
@@ -64,19 +66,22 @@
         v-model="form.chart.caption"
         label="Caption"
         :disabled="props.disabled"
+        spellcheck="false"
         class="mb-4"
       />
     </div>
     <div v-if="form.form === 'footer-create'">
       <s-text-field
         v-model="form.footer.textLeft"
         label="Footer Text Left (optional)"
+        spellcheck="false"
         class="mb-4"
         :disabled="props.disabled"
       />
       <s-text-field
         v-model="form.footer.textCenter"
         label="Footer Text Center (optional)"
+        spellcheck="false"
         class="mb-4"
         :disabled="props.disabled"
       />
@@ -108,6 +113,7 @@
         v-model="form.header.backgroundColor"
         label="Header background color (optional)"
         hint="CSS value: #ff0000 or rgb(255, 0, 0) or red"
+        spellcheck="false"
         class="mb-4"
         :disabled="props.disabled"
       />
@@ -116,6 +122,7 @@
       <s-text-field
         v-model="form.toc.headline"
         label="Headline"
+        spellcheck="false"
         class="mb-4"
         :disabled="props.disabled"
       />
@@ -139,6 +146,7 @@
         v-model="form.findingList.headline"
         label="Chapter Headline"
         :disabled="props.disabled"
+        spellcheck="false"
         class="mb-4"
       />
       <s-select

diff --git a/frontend/src/components/Design/designer-components.ts b/frontend/src/components/Design/designer-components.ts
@@ -539,7 +539,9 @@ export class FindingsChapterComponent extends DesignerComponentBase {
       htmlHeader = trimLeadingWhitespace(`
         <table class="finding-header">
           <thead>
-            <th colspan="2" class="finding-header-key text-center"><h2 :id="finding.id" class="in-toc">{{ finding.title }}</h2></th>
+            <tr>
+              <th colspan="2" class="finding-header-key text-center"><h2 :id="finding.id" class="in-toc">{{ finding.title }}</h2></th>
+            </tr>
           </thead>
           <tbody>
             <tr>
@@ -565,9 +567,9 @@ export class FindingsChapterComponent extends DesignerComponentBase {
             <td>
               <markdown v-if="finding.affected_components.length == 1" :text="finding.affected_components[0]" class="markdown-inline" />
               <ul v-else class="location-ul">
-                <template v-for="component in finding.affected_components">
-                  <li><markdown :text="component" class="markdown-inline" /></li>
-                </template>
+                <li v-for="component in finding.affected_components">
+                  <markdown :text="component" class="markdown-inline" />
+                </li>
               </ul>
             </td>
           </tr>

diff --git a/frontend/src/components/Markdown/Field.vue b/frontend/src/components/Markdown/Field.vue
@@ -35,5 +35,6 @@ function onControlClick() {
 .v-field__input {
   padding: 0 1px !important;
   cursor: initial !important;
+  row-gap: 0;
 }
 </style>