Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2

Open
wants to merge 4 commits into
base: pact21_ae_nohistory
Choose a base branch
from
Open

Bugfix #2

wants to merge 4 commits into from

Conversation

yjsoh
Copy link

@yjsoh yjsoh commented Oct 22, 2022

Few bug fixes

  • Backup location DRAM -> PMEM
  • Pointer arithmetic on void * is not what we want here
  • Fixed bug in fill_call_forwarding_entry.
  • Fixed get_sub_id() bug

Yun Joon Soh added 4 commits October 21, 2022 20:39
Fixed get_sub_id() bug
82215b1
Fixed bug in fill_call_forwarding_entry.
8dd7e7f 
Check the cftsz: it is 3 times the size of special_facility_entry.
12 * Subscriber ID results in out of bound.
Pointer arithemetic on void * is not what we want here
3927a03
Backup location DRAM -> PMEM
10009dd 
I don't immediately see how backing up to a volatile variable could make the program crash-consistent.
Furthermore, non-initilization assignment of objects, only shallow copy the object.

* Allocate per-thread backup on PMEM.
* Allocate per-thread valid bit on PMEM.
* memcpy instead of shallow copy.

[FUTURE] Deep copy operatorator?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yjsoh