Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny_skia: apply clip_mask to shadows #1

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

B0ney
Copy link

@B0ney B0ney commented Jan 2, 2025

I found that the shadow rendering code isn't using the clip bounds properly. leading to some artifacting.

Here's demo (I've modified the styling to show the shadows).

Without clip_mask
Screenshot_20250102_124705
Screenshot_20250102_124734

With clip_mask
Screenshot_20250102_124807
Screenshot_20250102_124814

Note that the text is still overwriting the shadows (for both cases). But I think this should get us closer :)

@T-256
Copy link
Owner

T-256 commented Jan 7, 2025

LGTM, and sorry for late response, I didn't enable notification for this repo.

@T-256 T-256 merged commit e77100a into T-256:skia-shadow Jan 7, 2025
@T-256
Copy link
Owner

T-256 commented Jan 7, 2025

With example at here I still get a little out of bounds shadows:
image

@B0ney
Copy link
Author

B0ney commented Jan 7, 2025

I'll have another look at it.

@B0ney
Copy link
Author

B0ney commented Jan 7, 2025

I've made another pr here: #2

I think that should finally solve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants